Re: [PATCH v2] afs: Fix memory leak in afs_put_sysnames()

2020-06-01 Thread David Howells
Markus Elfring wrote: > > sysnames should be freed after refcnt being decreased to zero in > > afs_put_sysnames(). > > How do you think about a wording variant like the following? > >Release the sysnames object after its reference counter was decreased >to zero. I would say "reference

Re: [PATCH v2] afs: Fix memory leak in afs_put_sysnames()

2020-06-01 Thread Markus Elfring
> sysnames should be freed after refcnt being decreased to zero in > afs_put_sysnames(). How do you think about a wording variant like the following? Release the sysnames object after its reference counter was decreased to zero. Will it matter to mention the size of the data structure

[PATCH v2] afs: Fix memory leak in afs_put_sysnames()

2020-06-01 Thread Zhihao Cheng
sysnames should be freed after refcnt being decreased to zero in afs_put_sysnames(). Signed-off-by: Zhihao Cheng Cc: # v4.17+ Fixes: 6f8880d8e681557 ("afs: Implement @sys substitution handling") --- fs/afs/proc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/proc.c b/fs/afs/proc.c