Re: [PATCH v2] fs: proc: task_mmu: show page size in /proc//numa_maps

2015-01-05 Thread Andrew Morton
On Mon, 5 Jan 2015 19:21:35 -0500 Rafael Aquini wrote: > > > > > > > > > > > > > + seq_printf(m, " kernelpagesize_kB=%lu", > > > > > vma_kernel_pagesize(vma) >> 10); > > > > > > > > This changes the format of the numa_maps file and can potentially break > > > > existing parsers. Please d

Re: [PATCH v2] fs: proc: task_mmu: show page size in /proc//numa_maps

2015-01-05 Thread Rafael Aquini
On Mon, Jan 05, 2015 at 03:20:37PM -0800, Andrew Morton wrote: > On Mon, 5 Jan 2015 17:55:05 -0500 Rafael Aquini wrote: > > > On Mon, Jan 05, 2015 at 01:35:00PM -0800, Andrew Morton wrote: > > > On Mon, 5 Jan 2015 12:44:31 -0500 Rafael Aquini > > > wrote: > > > > > > > This patch introduces '

Re: [PATCH v2] fs: proc: task_mmu: show page size in /proc//numa_maps

2015-01-05 Thread Rafael Aquini
On Mon, Jan 05, 2015 at 05:55:04PM -0500, Rafael Aquini wrote: > > > + seq_printf(m, " kernelpagesize_kB=%lu", vma_kernel_pagesize(vma) >> 10); > > > > This changes the format of the numa_maps file and can potentially break > > existing parsers. Please discuss. > > > > I'd complain about the pat

Re: [PATCH v2] fs: proc: task_mmu: show page size in /proc//numa_maps

2015-01-05 Thread Rafael Aquini
On Mon, Jan 05, 2015 at 01:35:00PM -0800, Andrew Morton wrote: > On Mon, 5 Jan 2015 12:44:31 -0500 Rafael Aquini wrote: > > > This patch introduces 'kernelpagesize_kB' line element to > > /proc//numa_maps > > report file in order to help identifying the size of pages that are backing > > memory

Re: [PATCH v2] fs: proc: task_mmu: show page size in /proc//numa_maps

2015-01-05 Thread Andrew Morton
On Mon, 5 Jan 2015 12:44:31 -0500 Rafael Aquini wrote: > This patch introduces 'kernelpagesize_kB' line element to > /proc//numa_maps > report file in order to help identifying the size of pages that are backing > memory areas mapped by a given task. This is specially useful to > help different

[PATCH v2] fs: proc: task_mmu: show page size in /proc//numa_maps

2015-01-05 Thread Rafael Aquini
This patch introduces 'kernelpagesize_kB' line element to /proc//numa_maps report file in order to help identifying the size of pages that are backing memory areas mapped by a given task. This is specially useful to help differentiating between HUGE and GIGANTIC page backed VMAs. This patch is bas