Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

2016-06-20 Thread Mika Westerberg
On Sun, Jun 19, 2016 at 08:54:32PM -0700, Bin Gao wrote: > > > +#define DRV_NAME "bxt_wcove_gpio" > > > > Drop this. > We have _TWO_ places using DRV_NAME(near the end of the file): > static struct platform_driver wcove_gpio_driver = { >.driver = { >.name = DRV_NAME, >

Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

2016-06-19 Thread Bin Gao
> > Looks good. I have couple of minor comments, see below. Thanks for review again. > > > + * Copyright (C) 2015 Intel Corporation. All rights reserved. > > It is 2016 now isn't it? :-) Will fix this in v3. > > +#define DRV_NAME "bxt_wcove_gpio" > > Drop this. We have _TWO_ places using DRV_

Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

2016-06-17 Thread Mika Westerberg
On Thu, Jun 16, 2016 at 02:22:08PM -0700, Bin Gao wrote: > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > This driver is based on gpio-crystalcove.c. Looks good. I have couple of minor comments, see below. > Signed-off-by: Ajay Thomas > Signed-off-by: Bin Gao > --- >

[PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

2016-06-16 Thread Bin Gao
This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- Changes in v2: - Typo fix (Whsikey --> Whiskey). - Included linux/gpio/driver.h instead of linux/gpio.h - Implemented .set