Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-05 Thread Michael Hennerich
On 04.04.2017 11:28, Peter Rosin wrote: *snip* *snip* +static int ltc4306_gpio_get(struct gpio_chip *chip, unsigned int offset) +{ + struct ltc4306 *data = gpiochip_get_data(chip); + int ret = 0; + + if (gpiochip_line_is_open_drain(chip, offset) || + (data->regs[LTC_

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-04 Thread Peter Rosin
*snip* *snip* >>> +static int ltc4306_gpio_get(struct gpio_chip *chip, unsigned int offset) >>> +{ >>> + struct ltc4306 *data = gpiochip_get_data(chip); >>> + int ret = 0; >>> + >>> + if (gpiochip_line_is_open_drain(chip, offset) || >>> + (data->regs[LTC_REG_MODE] & BIT(7 - offset))) {

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-04 Thread Michael Hennerich
On 31.03.2017 17:29, Peter Rosin wrote: Hi! Sorry for my incremental reviewing... There's a question for the gpio people below that I would like to have some confirmation on. Thanks! Hi Peter, Please find comments in-line. On 2017-03-29 12:15, michael.henner...@analog.com wrote: From: M

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-03 Thread Michael Hennerich
On 03.04.2017 16:20, Peter Rosin wrote: On 2017-04-03 15:36, Michael Hennerich wrote: On 03.04.2017 14:03, Peter Rosin wrote: On 2017-03-31 17:29, Peter Rosin wrote: Hi! Sorry for my incremental reviewing... Another incremental... On 2017-03-29 12:15, michael.henner...@analog.com wrote:

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-03 Thread Peter Rosin
On 2017-04-03 15:36, Michael Hennerich wrote: > On 03.04.2017 14:03, Peter Rosin wrote: >> On 2017-03-31 17:29, Peter Rosin wrote: >>> Hi! >>> >>> Sorry for my incremental reviewing... >>> >> >> Another incremental... >> >>> On 2017-03-29 12:15, michael.henner...@analog.com wrote: + + /*

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-03 Thread Michael Hennerich
On 03.04.2017 14:03, Peter Rosin wrote: On 2017-03-31 17:29, Peter Rosin wrote: Hi! Sorry for my incremental reviewing... Another incremental... On 2017-03-29 12:15, michael.henner...@analog.com wrote: + + /* Now create an adapter for each channel */ + for (num = 0; num < data

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-04-03 Thread Peter Rosin
On 2017-03-31 17:29, Peter Rosin wrote: > Hi! > > Sorry for my incremental reviewing... > Another incremental... > On 2017-03-29 12:15, michael.henner...@analog.com wrote: >> + >> +/* Now create an adapter for each channel */ >> +for (num = 0; num < data->chip->nchans; num++) { >> +

Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-03-31 Thread Peter Rosin
Hi! Sorry for my incremental reviewing... There's a question for the gpio people below that I would like to have some confirmation on. Thanks! On 2017-03-29 12:15, michael.henner...@analog.com wrote: > From: Michael Hennerich > > This patch adds support for the Analog Devices / Linear Technolo

[PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

2017-03-29 Thread michael.hennerich
From: Michael Hennerich This patch adds support for the Analog Devices / Linear Technology LTC4306 and LTC4305 4/2 Channel I2C Bus Multiplexer/Switches. The LTC4306 optionally provides two general purpose input/output pins (GPIOs) that can be configured as logic inputs, opendrain outputs or push-