Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Cong Wang
On Mon, Sep 8, 2014 at 4:54 PM, Trond Myklebust wrote: > On Wed, Aug 27, 2014 at 6:41 PM, Al Viro wrote: >> On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: >>> Cong Wang writes: >>> >>> > I saw the following kernel warning: >>> >>> Cong thanks for finding and tracking this.

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Trond Myklebust
On Wed, Aug 27, 2014 at 6:41 PM, Al Viro wrote: > On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: >> Cong Wang writes: >> >> > I saw the following kernel warning: >> >> Cong thanks for finding and tracking this. I was clearly asleep at the >> switch when I was testing my fix

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Alexei Starovoitov
On Mon, Sep 8, 2014 at 11:50 AM, Matt Mullins wrote: > On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: >> I have applied this patch and will push it to Linus after it has a >> little bit to sit in linux-next. what's the status of this patch? It's rc4 already and I keep seeing

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Matt Mullins
On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: > I have applied this patch and will push it to Linus after it has a > little bit to sit in linux-next. I also fairly reliably hit this warning with trinity, and with Cong's patch, it seems to be gone. If it helps get it pushed

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Matt Mullins
On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: I have applied this patch and will push it to Linus after it has a little bit to sit in linux-next. I also fairly reliably hit this warning with trinity, and with Cong's patch, it seems to be gone. If it helps get it pushed

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Alexei Starovoitov
On Mon, Sep 8, 2014 at 11:50 AM, Matt Mullins mmull...@twopensource.com wrote: On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: I have applied this patch and will push it to Linus after it has a little bit to sit in linux-next. what's the status of this patch? It's rc4

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Trond Myklebust
On Wed, Aug 27, 2014 at 6:41 PM, Al Viro v...@zeniv.linux.org.uk wrote: On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: Cong Wang xiyou.wangc...@gmail.com writes: I saw the following kernel warning: Cong thanks for finding and tracking this. I was clearly asleep at the

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-09-08 Thread Cong Wang
On Mon, Sep 8, 2014 at 4:54 PM, Trond Myklebust trond.mykleb...@primarydata.com wrote: On Wed, Aug 27, 2014 at 6:41 PM, Al Viro v...@zeniv.linux.org.uk wrote: On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: Cong Wang xiyou.wangc...@gmail.com writes: I saw the following

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-27 Thread Al Viro
On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: > Cong Wang writes: > > > I saw the following kernel warning: > > Cong thanks for finding and tracking this. I was clearly asleep at the > switch when I was testing my fix to the nfs client code :( > > I have applied this

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-27 Thread Al Viro
On Tue, Aug 19, 2014 at 09:20:38PM -0700, Eric W. Biederman wrote: Cong Wang xiyou.wangc...@gmail.com writes: I saw the following kernel warning: Cong thanks for finding and tracking this. I was clearly asleep at the switch when I was testing my fix to the nfs client code :( I have

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-20 Thread Trond Myklebust
On Wed, Aug 20, 2014 at 12:20 AM, Eric W. Biederman wrote: > Cong Wang writes: > >> I saw the following kernel warning: > > Cong thanks for finding and tracking this. I was clearly asleep at the > switch when I was testing my fix to the nfs client code :( > > I have applied this patch and will

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-20 Thread Trond Myklebust
On Wed, Aug 20, 2014 at 1:24 AM, Christian Kujau wrote: > On Tue, 19 Aug 2014 at 21:20, Eric W. Biederman wrote: > >> Cong Wang writes: >> >> > I saw the following kernel warning: >> >> Cong thanks for finding and tracking this. I was clearly asleep at the >> switch when I was testing my fix to

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-20 Thread Trond Myklebust
On Wed, Aug 20, 2014 at 1:24 AM, Christian Kujau li...@nerdbynature.de wrote: On Tue, 19 Aug 2014 at 21:20, Eric W. Biederman wrote: Cong Wang xiyou.wangc...@gmail.com writes: I saw the following kernel warning: Cong thanks for finding and tracking this. I was clearly asleep at the

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-20 Thread Trond Myklebust
On Wed, Aug 20, 2014 at 12:20 AM, Eric W. Biederman ebied...@xmission.com wrote: Cong Wang xiyou.wangc...@gmail.com writes: I saw the following kernel warning: Cong thanks for finding and tracking this. I was clearly asleep at the switch when I was testing my fix to the nfs client code :(

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-19 Thread Eric W. Biederman
Cong Wang writes: > I saw the following kernel warning: Cong thanks for finding and tracking this. I was clearly asleep at the switch when I was testing my fix to the nfs client code :( I have applied this patch and will push it to Linus after it has a little bit to sit in linux-next. Eric

Re: [PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-19 Thread Eric W. Biederman
Cong Wang xiyou.wangc...@gmail.com writes: I saw the following kernel warning: Cong thanks for finding and tracking this. I was clearly asleep at the switch when I was testing my fix to the nfs client code :( I have applied this patch and will push it to Linus after it has a little bit to sit

[PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-16 Thread Cong Wang
I saw the following kernel warning: [ 1852.321222] [ cut here ] [ 1852.326527] WARNING: CPU: 0 PID: 118 at fs/proc/generic.c:521 remove_proc_entry+0x154/0x16b() [ 1852.335630] remove_proc_entry: removing non-empty directory 'fs/nfsfs', leaking at least 'volumes' [

[PATCH v2] nfs: fix kernel warning when removing proc entry

2014-08-16 Thread Cong Wang
I saw the following kernel warning: [ 1852.321222] [ cut here ] [ 1852.326527] WARNING: CPU: 0 PID: 118 at fs/proc/generic.c:521 remove_proc_entry+0x154/0x16b() [ 1852.335630] remove_proc_entry: removing non-empty directory 'fs/nfsfs', leaking at least 'volumes' [