Re: [PATCH v2] security: mark expected switch fall-throughs and add a missing break

2019-02-22 Thread Gustavo A. R. Silva
On 2/22/19 11:53 AM, James Morris wrote: > On Fri, 22 Feb 2019, Gustavo A. R. Silva wrote: > >> Hi James, >> >> I wonder if you can take this, please. > > Ok -- I had thought you were sending all of these upstream across the > board. > > Yeah, I'm only doing that in cases where patches

Re: [PATCH v2] security: mark expected switch fall-throughs and add a missing break

2019-02-22 Thread James Morris
On Fri, 8 Feb 2019, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may > fall

Re: [PATCH v2] security: mark expected switch fall-throughs and add a missing break

2019-02-22 Thread James Morris
On Fri, 22 Feb 2019, Gustavo A. R. Silva wrote: > Hi James, > > I wonder if you can take this, please. Ok -- I had thought you were sending all of these upstream across the board. > > Thanks > -- > Gustavo > > On 2/18/19 8:53 PM, Gustavo A. R. Silva wrote: > > > > > > On 2/8/19 3:13 PM,

Re: [PATCH v2] security: mark expected switch fall-throughs and add a missing break

2019-02-22 Thread Gustavo A. R. Silva
Hi James, I wonder if you can take this, please. Thanks -- Gustavo On 2/18/19 8:53 PM, Gustavo A. R. Silva wrote: > > > On 2/8/19 3:13 PM, Mimi Zohar wrote: >> On Fri, 2019-02-08 at 14:54 -0600, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch >>>

Re: [PATCH v2] security: mark expected switch fall-throughs and add a missing break

2019-02-18 Thread Gustavo A. R. Silva
On 2/8/19 3:13 PM, Mimi Zohar wrote: > On Fri, 2019-02-08 at 14:54 -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >>

Re: [PATCH v2] security: mark expected switch fall-throughs and add a missing break

2019-02-08 Thread Mimi Zohar
On Fri, 2019-02-08 at 14:54 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > security/integrity/ima/ima_template_lib.c:85:10: warning: this statement

[PATCH v2] security: mark expected switch fall-throughs and add a missing break

2019-02-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: security/integrity/ima/ima_template_lib.c:85:10: warning: this statement may fall through [-Wimplicit-fallthrough=]