Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array

2019-02-14 Thread Chao Yu
On 2019/2/14 15:10, Gao Xiang wrote: > > > On 2019/2/14 14:46, Sheng Yong wrote: >> If it fails to read a shared xattr page, the inode's shared xattr array >> is not freed. The next time the inode's xattr is accessed, the previously >> allocated array is leaked. Nice catch! >> >> Signed-off-by:

Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array

2019-02-13 Thread Gao Xiang
On 2019/2/14 14:46, Sheng Yong wrote: > If it fails to read a shared xattr page, the inode's shared xattr array > is not freed. The next time the inode's xattr is accessed, the previously > allocated array is leaked. > > Signed-off-by: Sheng Yong LGTM, Fixes: b17500a0fdba ("staging: erofs: i

[PATCH v2] staging: erofs: fix memleak of inode's shared xattr array

2019-02-13 Thread Sheng Yong
If it fails to read a shared xattr page, the inode's shared xattr array is not freed. The next time the inode's xattr is accessed, the previously allocated array is leaked. Signed-off-by: Sheng Yong --- v2: * s/node/inode in commit message * add prefix `staging:' to the subject --- drivers/s