Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-23 Thread Tony Luck
On Fri, May 23, 2014 at 4:57 AM, Chen Yucong wrote: > If (mca_cfg.tolerant == 2 || mce_cfg.tolerant == 3), what can you do for > it? Maybe we need to look again at the effects of "tolerant" - and maybe specify what happens at various levels, There are some obvious silly bits of code (picking one

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-23 Thread Tony Luck
On Thu, May 22, 2014 at 6:32 PM, Chen Yucong wrote: > As Naoya Horiguchi says, this patch also have a small benefit that it > can reduce the processing time of monarch CPU. This is indeed a benefit - but I'm not super worried about performance of machine check handler. >/* > * No

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-23 Thread Chen Yucong
On Fri, 2014-05-23 at 11:10 +0200, Borislav Petkov wrote: > On Fri, May 23, 2014 at 09:32:19AM +0800, Chen Yucong wrote: > > ...if we reach a timeout, there is very little > > chance for recovering. Thought. the probability for this situation to > > happen is very slight, it's not impossible. Indee

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-23 Thread Borislav Petkov
On Fri, May 23, 2014 at 09:32:19AM +0800, Chen Yucong wrote: > ...if we reach a timeout, there is very little > chance for recovering. Thought. the probability for this situation to > happen is very slight, it's not impossible. Indeed, it's hard to know > the precise causes for timeout. Ok, enough

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-22 Thread Chen Yucong
On Wed, 2014-05-21 at 21:09 +, Luck, Tony wrote: > Please do give us more detail on the scenario that you see that would > make your new version behave better. > > I'm sure the current code has no races w.r.t. clearing mces_seen. The > monarch clears them all in mce_reign() before clearing mc

RE: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-21 Thread Luck, Tony
>> mce_regin, which is only called by monarch CPU, can be used for system >> panics as quickly as possible if there is a truly data corrupting error. >> But Monarch CPU don't have to help all other CPU to clean mces_clean. >> One advantage of Per-CPU is the isolation of errors propagation, being >>

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/21 12:19), Chen Yucong wrote: > On Wed, 2014-05-21 at 11:43 +0900, Hidetoshi Seto wrote: >> (2014/05/21 11:03), Chen Yucong wrote: >>> On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: (2014/05/20 11:11), Chen Yucong wrote: > mces_seen is a Per-CPU variable which should onl

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Chen Yucong
On Wed, 2014-05-21 at 11:43 +0900, Hidetoshi Seto wrote: > (2014/05/21 11:03), Chen Yucong wrote: > > On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: > >> (2014/05/20 11:11), Chen Yucong wrote: > >>> mces_seen is a Per-CPU variable which should only be accessed by Per-CPU > >>> as possibl

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/21 11:03), Chen Yucong wrote: > On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: >> (2014/05/20 11:11), Chen Yucong wrote: >>> mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as >>> possible. So the >>> clear operation of mces_seen should also be lcoal to

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Chen Yucong
On Wed, 2014-05-21 at 10:40 +0900, Hidetoshi Seto wrote: > (2014/05/20 11:11), Chen Yucong wrote: > > mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as > > possible. So the > > clear operation of mces_seen should also be lcoal to Per-CPU rather than > > monarch CPU. > >

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Hidetoshi Seto
(2014/05/20 11:11), Chen Yucong wrote: > mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as > possible. So the > clear operation of mces_seen should also be lcoal to Per-CPU rather than > monarch CPU. I don't think it should be local. Originally what we want to have here

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Chen Yucong
On Tue, 2014-05-20 at 19:33 +0200, Borislav Petkov wrote: > On Tue, May 20, 2014 at 10:11:25AM +0800, Chen Yucong wrote: > > mces_seen is a Per-CPU variable which should only be accessed by > > Per-CPU as possible. So the clear operation of mces_seen should also > > be lcoal to Per-CPU rather than

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Chen Yucong
On Tue, 2014-05-20 at 19:33 +0200, Borislav Petkov wrote: > On Tue, May 20, 2014 at 10:11:25AM +0800, Chen Yucong wrote: > > mces_seen is a Per-CPU variable which should only be accessed by > > Per-CPU as possible. So the clear operation of mces_seen should also > > be lcoal to Per-CPU rather than

Re: [PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-20 Thread Borislav Petkov
On Tue, May 20, 2014 at 10:11:25AM +0800, Chen Yucong wrote: > mces_seen is a Per-CPU variable which should only be accessed by > Per-CPU as possible. So the clear operation of mces_seen should also > be lcoal to Per-CPU rather than monarch CPU. > > Meanwhile, there is also a potential risk that mc

[PATCH v2] x86/mce: Distirbute the clear operation of mces_seen to Per-CPU rather than only monarch CPU

2014-05-19 Thread Chen Yucong
mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as possible. So the clear operation of mces_seen should also be lcoal to Per-CPU rather than monarch CPU. Meanwhile, there is also a potential risk that mces_seen will not be be cleared if a timeout occors in mce_end for m