Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-04-18 Thread Feng Tang
Hi All, On Wed, Apr 16, 2014 at 08:51:48AM +0200, Ingo Molnar wrote: > > * Feng Tang wrote: > > > > > > > > > > > > > > > > > I thought about this before, HPET doesn't have PCI ID like > > > > > > > > > stuff, > > > > > > > > > > > > > > > > HPET does have the PCI vendor ID in the first regis

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-04-15 Thread Ingo Molnar
* Feng Tang wrote: > On Tue, Apr 15, 2014 at 12:42:06PM +0200, Ingo Molnar wrote: > > > > * Feng Tang wrote: > > > > > On Tue, Apr 15, 2014 at 11:00:25AM +0200, Ingo Molnar wrote: > > > > > > > > * Feng Tang wrote: > > > > > > > > > Hi Ingo, > > > > > > > > > > On Fri, Mar 28, 2014 at 09:

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-04-15 Thread Feng Tang
On Tue, Apr 15, 2014 at 12:42:06PM +0200, Ingo Molnar wrote: > > * Feng Tang wrote: > > > On Tue, Apr 15, 2014 at 11:00:25AM +0200, Ingo Molnar wrote: > > > > > > * Feng Tang wrote: > > > > > > > Hi Ingo, > > > > > > > > On Fri, Mar 28, 2014 at 09:11:17AM +0100, Ingo Molnar wrote: > > > > >

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-04-15 Thread Ingo Molnar
* Feng Tang wrote: > On Tue, Apr 15, 2014 at 11:00:25AM +0200, Ingo Molnar wrote: > > > > * Feng Tang wrote: > > > > > Hi Ingo, > > > > > > On Fri, Mar 28, 2014 at 09:11:17AM +0100, Ingo Molnar wrote: > > > > > > > > * Clemens Ladisch wrote: > > > > > > > > > Feng Tang wrote: > > > > > >

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-04-15 Thread Feng Tang
On Tue, Apr 15, 2014 at 11:00:25AM +0200, Ingo Molnar wrote: > > * Feng Tang wrote: > > > Hi Ingo, > > > > On Fri, Mar 28, 2014 at 09:11:17AM +0100, Ingo Molnar wrote: > > > > > > * Clemens Ladisch wrote: > > > > > > > Feng Tang wrote: > > > > > On Fri, Mar 28, 2014 at 08:17:16AM +0100, Ingo

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-04-15 Thread Ingo Molnar
* Feng Tang wrote: > Hi Ingo, > > On Fri, Mar 28, 2014 at 09:11:17AM +0100, Ingo Molnar wrote: > > > > * Clemens Ladisch wrote: > > > > > Feng Tang wrote: > > > > On Fri, Mar 28, 2014 at 08:17:16AM +0100, Ingo Molnar wrote: > > > >> * Feng Tang wrote: > > > >> - or the kernel should have a

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-04-15 Thread Feng Tang
Hi Ingo, On Fri, Mar 28, 2014 at 09:11:17AM +0100, Ingo Molnar wrote: > > * Clemens Ladisch wrote: > > > Feng Tang wrote: > > > On Fri, Mar 28, 2014 at 08:17:16AM +0100, Ingo Molnar wrote: > > >> * Feng Tang wrote: > > >> - or the kernel should have a quirk to reliably disable it. Why > > >>

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-03-28 Thread Feng Tang
On Fri, Mar 28, 2014 at 09:11:17AM +0100, Ingo Molnar wrote: > > * Clemens Ladisch wrote: > > > Feng Tang wrote: > > > On Fri, Mar 28, 2014 at 08:17:16AM +0100, Ingo Molnar wrote: > > >> * Feng Tang wrote: > > >> - or the kernel should have a quirk to reliably disable it. Why > > >>should

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-03-28 Thread Ingo Molnar
* Clemens Ladisch wrote: > Feng Tang wrote: > > On Fri, Mar 28, 2014 at 08:17:16AM +0100, Ingo Molnar wrote: > >> * Feng Tang wrote: > >> - or the kernel should have a quirk to reliably disable it. Why > >>should we crash or misbehave if a driver is built into the > >>kernel? > > > > I

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-03-28 Thread Clemens Ladisch
Feng Tang wrote: > On Fri, Mar 28, 2014 at 08:17:16AM +0100, Ingo Molnar wrote: >> * Feng Tang wrote: >> - or the kernel should have a quirk to reliably disable it. Why >>should we crash or misbehave if a driver is built into the >>kernel? > > I thought about this before, HPET doesn't hav

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-03-28 Thread Feng Tang
Hi Ingo, Thanks for reviewing this On Fri, Mar 28, 2014 at 08:17:16AM +0100, Ingo Molnar wrote: > > * Feng Tang wrote: > > > On many new phone/tablet platforms like Baytrail/Merrifield etc, the > > HPET are either defeatured or has some problem to be used as a > > reliable timer. As these pl

Re: [PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-03-28 Thread Ingo Molnar
* Feng Tang wrote: > On many new phone/tablet platforms like Baytrail/Merrifield etc, the > HPET are either defeatured or has some problem to be used as a > reliable timer. As these platforms also have X86_64, we should not > make HPET_TIMER default y for all X86_64. NAK! If the HPET is unr

[PATCH v2] x86: hpet: Don't default CONFIG_HPET_TIMER to be y for X86_64

2014-03-27 Thread Feng Tang
On many new phone/tablet platforms like Baytrail/Merrifield etc, the HPET are either defeatured or has some problem to be used as a reliable timer. As these platforms also have X86_64, we should not make HPET_TIMER default y for all X86_64. Signed-off-by: Feng Tang --- arch/x86/Kconfig |7 ++