Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-08 Thread Sami Tolvanen
On Mon, Dec 07, 2015 at 02:07:43PM -0500, Mike Snitzer wrote: > I'm not seeing any verification of the metadata in fec_read_parity() -- > so it would seem that corrupt RS blocks would result in -EBADMSG being > returned from decode_rs8() (by virtue of incorrect parity being passed > to decode_rs8).

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-07 Thread Mike Snitzer
On Mon, Dec 07 2015 at 1:07pm -0500, Milan Broz wrote: > On 12/07/2015 05:31 PM, Sami Tolvanen wrote: > > On Mon, Dec 07, 2015 at 09:58:14AM -0500, Mike Snitzer wrote: > >> Great. Moving forward it'd be awesome if you could work to get your > >> verity FEC support regression tests into cryptset

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-07 Thread Milan Broz
On 12/07/2015 05:31 PM, Sami Tolvanen wrote: > On Mon, Dec 07, 2015 at 09:58:14AM -0500, Mike Snitzer wrote: >> Great. Moving forward it'd be awesome if you could work to get your >> verity FEC support regression tests into cryptsetup's tests. > > Sure. These tests would basically involve generat

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-07 Thread Sami Tolvanen
On Mon, Dec 07, 2015 at 09:58:14AM -0500, Mike Snitzer wrote: > Great. Moving forward it'd be awesome if you could work to get your > verity FEC support regression tests into cryptsetup's tests. Sure. These tests would basically involve generating a valid disk image, corrupting it up to the theor

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-07 Thread Mike Snitzer
On Mon, Dec 07 2015 at 8:21am -0500, Sami Tolvanen wrote: > On Fri, Dec 04, 2015 at 04:09:35PM -0500, Mike Snitzer wrote: > > I'd really appreciate it if you could do some regression testing, > > etc on your end to verify I didn't break anything while tweaking > > things. > > Sure. The changes

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-07 Thread Sami Tolvanen
On Fri, Dec 04, 2015 at 04:09:35PM -0500, Mike Snitzer wrote: > I'd really appreciate it if you could do some regression testing, > etc on your end to verify I didn't break anything while tweaking > things. Sure. The changes look fine. I applied them to my tree and everything still works as expect

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-04 Thread Mike Snitzer
On Fri, Dec 04 2015 at 5:03P -0500, Sami Tolvanen wrote: > On Thu, Dec 03, 2015 at 06:05:38PM -0500, Mike Snitzer wrote: > > If you're OK with those changes I'll fold that commit into your main FEC > > commit. > > Yes, these changes look fine. Thanks! OK, I reviewed the FEC code and have stage

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-04 Thread Sami Tolvanen
On Thu, Dec 03, 2015 at 06:05:38PM -0500, Mike Snitzer wrote: > If you're OK with those changes I'll fold that commit into your main FEC > commit. Yes, these changes look fine. Thanks! Sami -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majo

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-03 Thread Mike Snitzer
On Thu, Dec 03 2015 at 2:54pm -0500, Mike Snitzer wrote: > On Thu, Dec 03 2015 at 9:26am -0500, > Sami Tolvanen wrote: > > > Changes since v1: > > > > - Added CONFIG_DM_VERITY_FEC and split error correction into > > dm-verity-fec.[ch] to further separate the functionality from the > >

Re: [PATCH v2 0/2] dm verity: add support for error correction

2015-12-03 Thread Mike Snitzer
On Thu, Dec 03 2015 at 9:26am -0500, Sami Tolvanen wrote: > Changes since v1: > > - Added CONFIG_DM_VERITY_FEC and split error correction into > dm-verity-fec.[ch] to further separate the functionality from the > rest of dm-verity. Follows the same pattern as dm-uevent. > > - Added

[PATCH v2 0/2] dm verity: add support for error correction

2015-12-03 Thread Sami Tolvanen
Changes since v1: - Added CONFIG_DM_VERITY_FEC and split error correction into dm-verity-fec.[ch] to further separate the functionality from the rest of dm-verity. Follows the same pattern as dm-uevent. - Added missing dependencies for REED_SOLOMON to Kconfig. - Renamed dm-verity.c