Re: [PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()

2013-02-04 Thread Tejun Heo
Hey, On Mon, Feb 04, 2013 at 01:10:34PM -0500, chas williams - CONTRACTOR wrote: > you assign id1 to 0, so this never happens i think. i don't think the > reason to preassign id1/id2 exists anymore once the do loop is removed. > > > + id1 = idr_alloc(>idr, handle1, 0, 0,

Re: [PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()

2013-02-04 Thread chas williams - CONTRACTOR
On Mon, 4 Feb 2013 09:52:10 -0800 Tejun Heo wrote: > Subject: atm/nicstar: convert to idr_alloc() > > Convert to the much saner new idr interface. The existing code looks > buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as > lower limit and there's no error handling after

[PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()

2013-02-04 Thread Tejun Heo
Subject: atm/nicstar: convert to idr_alloc() Convert to the much saner new idr interface. The existing code looks buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as lower limit and there's no error handling after partial success. This conversion keeps the bugs unchanged. Only

[PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()

2013-02-04 Thread Tejun Heo
Subject: atm/nicstar: convert to idr_alloc() Convert to the much saner new idr interface. The existing code looks buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as lower limit and there's no error handling after partial success. This conversion keeps the bugs unchanged. Only

Re: [PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()

2013-02-04 Thread chas williams - CONTRACTOR
On Mon, 4 Feb 2013 09:52:10 -0800 Tejun Heo t...@kernel.org wrote: Subject: atm/nicstar: convert to idr_alloc() Convert to the much saner new idr interface. The existing code looks buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as lower limit and there's no error

Re: [PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()

2013-02-04 Thread Tejun Heo
Hey, On Mon, Feb 04, 2013 at 01:10:34PM -0500, chas williams - CONTRACTOR wrote: you assign id1 to 0, so this never happens i think. i don't think the reason to preassign id1/id2 exists anymore once the do loop is removed. + id1 = idr_alloc(card-idr, handle1, 0, 0,