Re: [PATCH v2 04/12] software_node: Enforce parent before child ordering of nodes arrays

2020-12-19 Thread Daniel Scally
On 18/12/2020 20:29, Andy Shevchenko wrote: >> + * Register multiple software nodes at once. If any node in the array >> + * has it's .parent pointer set, then it's parent **must** have been > > it's => its in both cases? Done, ty >> + * registered before it is; either outside of this function

Re: [PATCH v2 04/12] software_node: Enforce parent before child ordering of nodes arrays

2020-12-18 Thread Daniel Scally
Hi Laurent On 18/12/2020 16:02, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Thu, Dec 17, 2020 at 11:43:29PM +, Daniel Scally wrote: >> Registering software_nodes with the .parent member set to point to a >> currently unregistered software_node has the potential

Re: [PATCH v2 04/12] software_node: Enforce parent before child ordering of nodes arrays

2020-12-18 Thread Andy Shevchenko
On Thu, Dec 17, 2020 at 11:43:29PM +, Daniel Scally wrote: > Registering software_nodes with the .parent member set to point to a > currently unregistered software_node has the potential for problems, > so enforce parent -> child ordering in arrays passed in to >

Re: [PATCH v2 04/12] software_node: Enforce parent before child ordering of nodes arrays

2020-12-18 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Thu, Dec 17, 2020 at 11:43:29PM +, Daniel Scally wrote: > Registering software_nodes with the .parent member set to point to a > currently unregistered software_node has the potential for problems, > so enforce parent -> child ordering in arrays passed

[PATCH v2 04/12] software_node: Enforce parent before child ordering of nodes arrays

2020-12-17 Thread Daniel Scally
Registering software_nodes with the .parent member set to point to a currently unregistered software_node has the potential for problems, so enforce parent -> child ordering in arrays passed in to software_node_register_nodes(). Software nodes that are children of another software node should be