Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

2014-06-28 Thread Michael Welling
Looking at the driver the define you are fixing isn't even used. So it could be removed. While you are at it you may want to remove the peice of completey redundant code. . . if (ret) goto error_ret; error_ret: . . Wow. On Sat, Jun 28, 2014 at 05:10:46AM +0200, Guillaume

Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

2014-06-27 Thread Michael Welling
On Sat, Jun 28, 2014 at 05:10:46AM +0200, Guillaume Morin wrote: > On 27 Jun 22:37, Greg Kroah-Hartman wrote: > > Put that below the --- line. > > Will do. > > > > > And what checkpatch error did you fix? And are you sure it needs to be > > > > fixed? > > > > > > That's what I changed: > > > >

Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

2014-06-27 Thread Guillaume Morin
On 27 Jun 22:37, Greg Kroah-Hartman wrote: > Put that below the --- line. Will do. > > > And what checkpatch error did you fix? And are you sure it needs to be > > > fixed? > > > > That's what I changed: > > > > $ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c > > ERROR: Macro

Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

2014-06-27 Thread Greg Kroah-Hartman
On Sat, Jun 28, 2014 at 04:30:09AM +0200, Guillaume Morin wrote: > On 27 Jun 19:09, Greg Kroah-Hartman wrote: > > > v2: add missing Signed-off-by > > > > That doesn't go here. > > I guess I am struggling to get git send-email do what I want Put that below the --- line. > > And what checkpatch

Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

2014-06-27 Thread Guillaume Morin
On 27 Jun 19:09, Greg Kroah-Hartman wrote: > > v2: add missing Signed-off-by > > That doesn't go here. I guess I am struggling to get git send-email do what I want > And what checkpatch error did you fix? And are you sure it needs to be > fixed? That's what I changed: $ scripts/checkpatch.pl

Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

2014-06-27 Thread Greg Kroah-Hartman
On Sat, Jun 28, 2014 at 03:46:56AM +0200, Guillaume Morin wrote: > v2: add missing Signed-off-by That doesn't go here. And what checkpatch error did you fix? And are you sure it needs to be fixed? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

[PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

2014-06-27 Thread Guillaume Morin
v2: add missing Signed-off-by Signed-off-by: Guillaume Morin diff --git a/drivers/staging/iio/frequency/ad9850.c b/drivers/staging/iio/frequency/ad9850.c index af877ff..6183670 100644 --- a/drivers/staging/iio/frequency/ad9850.c +++ b/drivers/staging/iio/frequency/ad9850.c @@ -21,7 +21,7 @@