Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-03-02 Thread Jonathan Richardson
Hi Dmitry, Thanks for the review. I'll fix everything as suggested. One comment below. New patchset coming once I can test the latest DT bindings in Hans de Goede's patch. Thanks, Jon On 15-02-24 03:29 PM, Dmitry Torokhov wrote: > Hi Jonathan, > > On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonat

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-02-26 Thread Jonathan Richardson
Hi Dmitry, Thanks. I'll go through his patch and make the appropriate changes to our driver. Jon On 15-02-24 03:18 PM, Dmitry Torokhov wrote: > Jonathan, > > > On Wed, Feb 11, 2015 at 10:45:34AM -0800, Jonathan Richardson wrote: >> Pinging maintainers... Am I ok to go ahead with the current ro

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-02-24 Thread Dmitry Torokhov
Hi Jonathan, On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wrote: > Add initial version of the Broadcom touchscreen driver. > > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > Tested-by: Scott Branden > Signed-off-by: Jonathan Richardson > --- > drivers/input/touchscreen/

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-02-24 Thread Dmitry Torokhov
Jonathan, On Wed, Feb 11, 2015 at 10:45:34AM -0800, Jonathan Richardson wrote: > Pinging maintainers... Am I ok to go ahead with the current rotation > implementation? I haven't heard anything further. Any feedback on naming > conventions from DT people? > I believe we should go with touchscreen

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-02-11 Thread Jonathan Richardson
Pinging maintainers... Am I ok to go ahead with the current rotation implementation? I haven't heard anything further. Any feedback on naming conventions from DT people? Thanks! On 15-01-15 11:51 AM, Jonathan Richardson wrote: > Hi Dmitry, > > On 15-01-14 10:07 PM, Dmitry Torokhov wrote: >> On W

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-15 Thread Jonathan Richardson
Hi Dmitry, On 15-01-14 10:07 PM, Dmitry Torokhov wrote: > On Wed, Jan 14, 2015 at 09:44:39PM -0800, Scott Branden wrote: >> On 15-01-14 05:02 PM, Dmitry Torokhov wrote: >>> Hi Jonathan, >>> >>> On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wrote: + if (of_property_read_u32(np

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-15 Thread Jonathan Richardson
On 15-01-14 05:08 PM, Florian Fainelli wrote: > On 19/12/14 15:03, Jonathan Richardson wrote: >> On 14-12-19 02:26 PM, Joe Perches wrote: >>> On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: Add initial version of the Broadcom touchscreen driver. >>> >>> more trivia: >>> diff

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-14 Thread Dmitry Torokhov
On Wed, Jan 14, 2015 at 09:44:39PM -0800, Scott Branden wrote: > On 15-01-14 05:02 PM, Dmitry Torokhov wrote: > >Hi Jonathan, > > > >On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wrote: > >>+ if (of_property_read_u32(np, "scanning_period", &val) >= 0) { > >>+ if (val < 1

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-14 Thread Scott Branden
On 15-01-14 05:02 PM, Dmitry Torokhov wrote: Hi Jonathan, On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wrote: + if (of_property_read_u32(np, "scanning_period", &val) >= 0) { + if (val < 1 || val > 256) { + dev_err(dev, "scanning_period

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-14 Thread Florian Fainelli
On 19/12/14 15:03, Jonathan Richardson wrote: > On 14-12-19 02:26 PM, Joe Perches wrote: >> On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: >>> Add initial version of the Broadcom touchscreen driver. >> >> more trivia: >> >>> diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c >>>

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-14 Thread Dmitry Torokhov
Hi Jonathan, On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wrote: > + if (of_property_read_u32(np, "scanning_period", &val) >= 0) { > + if (val < 1 || val > 256) { > + dev_err(dev, "scanning_period must be [1-256]\n"); > + ret

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2014-12-31 Thread Jonathan Richardson
Hi, Would anyone be able to look at this to help us move forward? Thanks. On 14-12-19 03:03 PM, Jonathan Richardson wrote: > On 14-12-19 02:26 PM, Joe Perches wrote: >> On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: >>> Add initial version of the Broadcom touchscreen driver. >> >>

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2014-12-19 Thread Jonathan Richardson
On 14-12-19 02:26 PM, Joe Perches wrote: > On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: >> Add initial version of the Broadcom touchscreen driver. > > more trivia: > >> diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c >> b/drivers/input/touchscreen/bcm_iproc_tsc.c > [] >>

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2014-12-19 Thread Joe Perches
On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: > Add initial version of the Broadcom touchscreen driver. more trivia: > diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c > b/drivers/input/touchscreen/bcm_iproc_tsc.c [] > +static int get_tsc_config(struct device_node *np, stru

[PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2014-12-19 Thread Jonathan Richardson
Add initial version of the Broadcom touchscreen driver. Reviewed-by: Ray Jui Reviewed-by: Scott Branden Tested-by: Scott Branden Signed-off-by: Jonathan Richardson --- drivers/input/touchscreen/Kconfig | 11 + drivers/input/touchscreen/Makefile|1 + drivers/input/touchsc