Re: [PATCH v2 1/2] mmc: sdhci-esdhc-imx: disable clocks before changing frequency

2018-07-16 Thread Ulf Hansson
On 12 July 2018 at 10:06, Stefan Agner wrote: > In the uSDHC case (e.g. i.MX 6) clocks only get disabled if frequency > is set to 0. However, it could be that the stack asks for a frequency > change while clocks are on. In that case the function clears the > divider registers (by clearing ESDHC_CL

Re: [PATCH v2 1/2] mmc: sdhci-esdhc-imx: disable clocks before changing frequency

2018-07-12 Thread Adrian Hunter
On 12/07/18 11:07, Stefan Agner wrote: > In the uSDHC case (e.g. i.MX 6) clocks only get disabled if frequency > is set to 0. However, it could be that the stack asks for a frequency > change while clocks are on. In that case the function clears the > divider registers (by clearing ESDHC_CLOCK_MASK

RE: [PATCH v2 1/2] mmc: sdhci-esdhc-imx: disable clocks before changing frequency

2018-07-12 Thread A.s. Dong
nel.org; Stefan Agner > > Subject: [PATCH v2 1/2] mmc: sdhci-esdhc-imx: disable clocks before > changing frequency > > In the uSDHC case (e.g. i.MX 6) clocks only get disabled if frequency is set > to 0. > However, it could be that the stack asks for a frequency change while clocks

Re: [PATCH v2 1/2] mmc: sdhci-esdhc-imx: disable clocks before changing frequency

2018-07-12 Thread Stefan Agner
On 12.07.2018 10:06, Stefan Agner wrote: > In the uSDHC case (e.g. i.MX 6) clocks only get disabled if frequency > is set to 0. However, it could be that the stack asks for a frequency > change while clocks are on. In that case the function clears the > divider registers (by clearing ESDHC_CLOCK_MA

[PATCH v2 1/2] mmc: sdhci-esdhc-imx: disable clocks before changing frequency

2018-07-12 Thread Stefan Agner
In the uSDHC case (e.g. i.MX 6) clocks only get disabled if frequency is set to 0. However, it could be that the stack asks for a frequency change while clocks are on. In that case the function clears the divider registers (by clearing ESDHC_CLOCK_MASK) while the clock is enabled! This causes a sho

[PATCH v2 1/2] mmc: sdhci-esdhc-imx: disable clocks before changing frequency

2018-07-12 Thread Stefan Agner
In the uSDHC case (e.g. i.MX 6) clocks only get disabled if frequency is set to 0. However, it could be that the stack asks for a frequency change while clocks are on. In that case the function clears the divider registers (by clearing ESDHC_CLOCK_MASK) while the clock is enabled! This causes a sho