Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-27 Thread Andrey Pronin
On Wed, Jul 20, 2016 at 01:54:22PM -0600, Jason Gunthorpe wrote: > On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > > > Sorry, I just updated this patch description in v2 to indicate why they are > > not > > hard-coded, but didn't answer explicitly. As the firmware changes, a >

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-27 Thread Andrey Pronin
On Wed, Jul 20, 2016 at 01:54:22PM -0600, Jason Gunthorpe wrote: > On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > > > Sorry, I just updated this patch description in v2 to indicate why they are > > not > > hard-coded, but didn't answer explicitly. As the firmware changes, a >

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-27 Thread Andrey Pronin
On Thu, Jul 21, 2016 at 04:03:12PM -0500, Rob Herring wrote: > On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > > On Wed, Jul 20, 2016 at 02:03:03PM -0500, Rob Herring wrote: > > > On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: > > > > Hi Rob, > > > > > As I

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-27 Thread Andrey Pronin
On Thu, Jul 21, 2016 at 04:03:12PM -0500, Rob Herring wrote: > On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > > On Wed, Jul 20, 2016 at 02:03:03PM -0500, Rob Herring wrote: > > > On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: > > > > Hi Rob, > > > > > As I

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-21 Thread Rob Herring
On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > On Wed, Jul 20, 2016 at 02:03:03PM -0500, Rob Herring wrote: > > On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: > > Hi Rob, > > > As I mentioned, there may be common properties. It doesn't seem you > > looked, so I

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-21 Thread Rob Herring
On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > On Wed, Jul 20, 2016 at 02:03:03PM -0500, Rob Herring wrote: > > On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: > > Hi Rob, > > > As I mentioned, there may be common properties. It doesn't seem you > > looked, so I

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-20 Thread Jason Gunthorpe
On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > Sorry, I just updated this patch description in v2 to indicate why they are > not > hard-coded, but didn't answer explicitly. As the firmware changes, a different > revision of it can have a different time before it sleeps in its

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-20 Thread Jason Gunthorpe
On Wed, Jul 20, 2016 at 12:49:12PM -0700, Andrey Pronin wrote: > Sorry, I just updated this patch description in v2 to indicate why they are > not > hard-coded, but didn't answer explicitly. As the firmware changes, a different > revision of it can have a different time before it sleeps in its

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-20 Thread Andrey Pronin
On Wed, Jul 20, 2016 at 02:03:03PM -0500, Rob Herring wrote: > On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: Hi Rob, > As I mentioned, there may be common properties. It doesn't seem you > looked, so I did: > > - spi-rx-delay-us - (optional) Microsecond delay after a read

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-20 Thread Andrey Pronin
On Wed, Jul 20, 2016 at 02:03:03PM -0500, Rob Herring wrote: > On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: Hi Rob, > As I mentioned, there may be common properties. It doesn't seem you > looked, so I did: > > - spi-rx-delay-us - (optional) Microsecond delay after a read

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-20 Thread Rob Herring
On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: > Add TPM2.0 PTP FIFO compatible SPI interface for chips with Cr50 > firmware. Several timing-related properties that may differ from > one firmware version to another are added to devicetree. > Document these properties. > >

Re: [PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-20 Thread Rob Herring
On Tue, Jul 19, 2016 at 08:41:24PM -0700, Andrey Pronin wrote: > Add TPM2.0 PTP FIFO compatible SPI interface for chips with Cr50 > firmware. Several timing-related properties that may differ from > one firmware version to another are added to devicetree. > Document these properties. > >

[PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-19 Thread Andrey Pronin
Add TPM2.0 PTP FIFO compatible SPI interface for chips with Cr50 firmware. Several timing-related properties that may differ from one firmware version to another are added to devicetree. Document these properties. Signed-off-by: Andrey Pronin ---

[PATCH v2 1/2] tpm: devicetree: document properties for cr50

2016-07-19 Thread Andrey Pronin
Add TPM2.0 PTP FIFO compatible SPI interface for chips with Cr50 firmware. Several timing-related properties that may differ from one firmware version to another are added to devicetree. Document these properties. Signed-off-by: Andrey Pronin ---