Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-03-01 Thread Boris Brezillon
On Wed, 1 Mar 2017 09:38:07 +0100 Hans-Christian Noren Egtvedt wrote: > Around Wed 01 Mar 2017 09:22:24 +0100 or thereabout, Boris Brezillon wrote: > > Hi Hans-Christian, > > > > On Fri, 24 Feb 2017 10:04:35 +0100 > > Hans-Christian Noren Egtvedt wrote: > > > >> Around Fri 24 Feb 2017 09:55:

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-03-01 Thread Boris Brezillon
Hi Hans-Christian, On Fri, 24 Feb 2017 10:04:35 +0100 Hans-Christian Noren Egtvedt wrote: > Around Fri 24 Feb 2017 09:55:09 +0100 or thereabout, Boris Brezillon wrote: > > On Fri, 24 Feb 2017 09:52:09 +0100 > > Hans-Christian Noren Egtvedt wrote: > >> Around Fri 24 Feb 2017 09:27:42 +0100 or

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-03-01 Thread Hans-Christian Noren Egtvedt
Around Wed 01 Mar 2017 09:22:24 +0100 or thereabout, Boris Brezillon wrote: > Hi Hans-Christian, > > On Fri, 24 Feb 2017 10:04:35 +0100 > Hans-Christian Noren Egtvedt wrote: > >> Around Fri 24 Feb 2017 09:55:09 +0100 or thereabout, Boris Brezillon wrote: >> > On Fri, 24 Feb 2017 09:52:09 +0100 >

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Andy Shevchenko
On Fri, Feb 24, 2017 at 11:51 AM, Alexandre Belloni wrote: > On 24/02/2017 at 10:04:35 +0100, Hans-Christian Noren Egtvedt wrote: >> Around Fri 24 Feb 2017 09:55:09 +0100 or thereabout, Boris Brezillon wrote: >> > On Fri, 24 Feb 2017 09:52:09 +0100 >> > Hans-Christian Noren Egtvedt wrote: > I th

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Hans-Christian Noren Egtvedt
Around Fri 24 Feb 2017 09:55:09 +0100 or thereabout, Boris Brezillon wrote: > On Fri, 24 Feb 2017 09:52:09 +0100 > Hans-Christian Noren Egtvedt wrote: >> Around Fri 24 Feb 2017 09:27:42 +0100 or thereabout, Boris Brezillon wrote: >> > On Fri, 24 Feb 2017 09:14:30 +0100 Hans-Christian Noren Egtvedt

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Alexandre Belloni
On 24/02/2017 at 10:04:35 +0100, Hans-Christian Noren Egtvedt wrote: > Around Fri 24 Feb 2017 09:55:09 +0100 or thereabout, Boris Brezillon wrote: > > On Fri, 24 Feb 2017 09:52:09 +0100 > > Hans-Christian Noren Egtvedt wrote: > >> OK, I will try to prepare it during the weekend. > >> > >> Any rea

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Hans-Christian Noren Egtvedt
Around Thu 23 Feb 2017 21:18:13 -0800 or thereabout, Håvard Skinnemoen wrote: > On Tue, Feb 21, 2017 at 9:14 AM, Alexandre Belloni > wrote: >> On 21/02/2017 at 18:43:35 +0200, Andy Shevchenko wrote: >> A few weeks ago, I was telling Boris to let it not build for a while and >> then remove it. Y

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Boris Brezillon
On Fri, 24 Feb 2017 10:04:35 +0100 Hans-Christian Noren Egtvedt wrote: > Around Fri 24 Feb 2017 09:55:09 +0100 or thereabout, Boris Brezillon wrote: > > On Fri, 24 Feb 2017 09:52:09 +0100 > > Hans-Christian Noren Egtvedt wrote: > >> Around Fri 24 Feb 2017 09:27:42 +0100 or thereabout, Boris Br

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Hans-Christian Noren Egtvedt
Around Fri 24 Feb 2017 09:27:42 +0100 or thereabout, Boris Brezillon wrote: > On Fri, 24 Feb 2017 09:14:30 +0100 Hans-Christian Noren Egtvedt > wrote: >> Around Thu 23 Feb 2017 21:18:13 -0800 or thereabout, Håvard Skinnemoen wrote: >> > On Tue, Feb 21, 2017 at 9:14 AM, Alexandre Belloni >> > wro

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Alexandre Belloni
On 24/02/2017 at 09:14:30 +0100, Hans-Christian Noren Egtvedt wrote: > Around Thu 23 Feb 2017 21:18:13 -0800 or thereabout, Håvard Skinnemoen wrote: > > On Tue, Feb 21, 2017 at 9:14 AM, Alexandre Belloni > > wrote: > >> On 21/02/2017 at 18:43:35 +0200, Andy Shevchenko wrote: > > > > >> A few we

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Boris Brezillon
On Fri, 24 Feb 2017 09:52:09 +0100 Hans-Christian Noren Egtvedt wrote: > Around Fri 24 Feb 2017 09:27:42 +0100 or thereabout, Boris Brezillon wrote: > > On Fri, 24 Feb 2017 09:14:30 +0100 Hans-Christian Noren Egtvedt > > wrote: > >> Around Thu 23 Feb 2017 21:18:13 -0800 or thereabout, Håvard

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-24 Thread Boris Brezillon
Hi Hans-Cristrian, On Fri, 24 Feb 2017 09:14:30 +0100 Hans-Christian Noren Egtvedt wrote: > Around Thu 23 Feb 2017 21:18:13 -0800 or thereabout, Håvard Skinnemoen wrote: > > On Tue, Feb 21, 2017 at 9:14 AM, Alexandre Belloni > > wrote: > >> On 21/02/2017 at 18:43:35 +0200, Andy Shevchenko wro

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-23 Thread Håvard Skinnemoen
On Tue, Feb 21, 2017 at 9:14 AM, Alexandre Belloni wrote: > On 21/02/2017 at 18:43:35 +0200, Andy Shevchenko wrote: >> >> Come on, v4.10 has just been release and >> >> It doesn't build anymore. And current case even worse >> Face it. It's dead. >> > > I agree it hasn't seen any significant develo

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Alexandre Belloni
On 21/02/2017 at 18:43:35 +0200, Andy Shevchenko wrote: > >> Come on, v4.10 has just been release and > > It doesn't build anymore. And current case even worse > Face it. It's dead. > I agree it hasn't seen any significant development in a while but I'm not the on able to take that decision. A

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Alexandre Belloni
On 21/02/2017 at 18:32:26 +0200, Andy Shevchenko wrote: > I did it ~year or so before where another relocation bug was discovered > (fixed). > > > please feel free to > > send a patch to remove the whole architecture. > > The benefits for atmel will be: proper big endian support, removal of > > p

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2017 at 6:32 PM, Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 6:21 PM, Alexandre Belloni > wrote: >> On 21/02/2017 at 18:09:09 +0200, Andy Shevchenko wrote: >>> On Tue, Feb 21, 2017 at 1:27 PM, Alexandre Belloni >>> wrote: >>> > On 21/02/2017 at 13:02:21 +0200, Andy Shevchenk

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2017 at 6:21 PM, Alexandre Belloni wrote: > On 21/02/2017 at 18:09:09 +0200, Andy Shevchenko wrote: >> On Tue, Feb 21, 2017 at 1:27 PM, Alexandre Belloni >> wrote: >> > On 21/02/2017 at 13:02:21 +0200, Andy Shevchenko wrote: >> >> Abusing platform data with pointers is also not we

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Alexandre Belloni
On 21/02/2017 at 18:09:09 +0200, Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 1:27 PM, Alexandre Belloni > wrote: > > (adding Hans-Christian) > > > > On 21/02/2017 at 13:02:21 +0200, Andy Shevchenko wrote: > >> Abusing platform data with pointers is also not welcome. > >> > >> > (in this case,

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Alexandre Belloni
On 21/02/2017 at 17:55:15 +0200, Andy Shevchenko wrote: > > And how do you do with new drivers? > > To be more pedantic the new drivers do not have "minus" thousands LOC. Because all the "minus" are located in the same file (the one that disappear), they can be safely ignored. So it is basically

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2017 at 1:27 PM, Alexandre Belloni wrote: > (adding Hans-Christian) > > On 21/02/2017 at 13:02:21 +0200, Andy Shevchenko wrote: >> Abusing platform data with pointers is also not welcome. >> >> > (in this case, avr32). >> >> It's dead de facto. >> >> When last time did you compile

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2017 at 1:20 PM, Boris Brezillon wrote: > On Tue, 21 Feb 2017 13:02:21 +0200 > Andy Shevchenko wrote: >> On Tue, Feb 21, 2017 at 12:26 PM, Boris Brezillon >> wrote: >> > On Tue, 21 Feb 2017 12:03:45 +0200 >> > Andy Shevchenko wrote: > So, it's a matter of taste. Yes, and I'm n

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Russell King - ARM Linux
On Tue, Feb 21, 2017 at 01:02:21PM +0200, Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 12:26 PM, Boris Brezillon > wrote: > > On Tue, 21 Feb 2017 12:03:45 +0200 > > Andy Shevchenko wrote: > > >> 1. For example, > >> > >> #define ATMEL_NFC_CMD(pos, cmd)((cmd) << > >> (

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Nicolas Ferre
Le 21/02/2017 à 12:20, Boris Brezillon a écrit : >>> (in this case, avr32). >> It's dead de facto. >> >> When last time did you compile kernel for it? What was the version of kernel? >> Did it get successfully? Alexandre answered to this one. >> When are we going to remove avr32 support from ke

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Nicolas Ferre
Le 20/02/2017 à 13:28, Boris Brezillon a écrit : > This is a complete rewrite of the driver whose main purpose is to > support the new DT representation where the NAND controller node is now > really visible in the DT and appears under the EBI bus. With this new > representation, we can add other d

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Alexandre Belloni
(adding Hans-Christian) On 21/02/2017 at 13:02:21 +0200, Andy Shevchenko wrote: > Abusing platform data with pointers is also not welcome. > > > (in this case, avr32). > > It's dead de facto. > > When last time did you compile kernel for it? What was the version of kernel? > Did it get successf

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Boris Brezillon
On Tue, 21 Feb 2017 13:02:21 +0200 Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 12:26 PM, Boris Brezillon > wrote: > > On Tue, 21 Feb 2017 12:03:45 +0200 > > Andy Shevchenko wrote: > > >> 1. For example, > >> > >> #define ATMEL_NFC_CMD(pos, cmd)((cmd) << > >> (((p

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2017 at 12:26 PM, Boris Brezillon wrote: > On Tue, 21 Feb 2017 12:03:45 +0200 > Andy Shevchenko wrote: >> 1. For example, >> >> #define ATMEL_NFC_CMD(pos, cmd)((cmd) << >> (((pos) * 8) + 2)) > > Well, I like to explicitly put parenthesis even when operator

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Nicolas Ferre
Le 21/02/2017 à 11:26, Boris Brezillon a écrit : > On Tue, 21 Feb 2017 12:03:45 +0200 > Andy Shevchenko wrote: > >> On Tue, Feb 21, 2017 at 10:06 AM, Boris Brezillon >> wrote: >>> On Tue, 21 Feb 2017 01:54:37 +0200 >>> Andy Shevchenko wrote: >>> On Tue, Feb 21, 2017 at 1:40 AM, Andy Shev

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Boris Brezillon
On Tue, 21 Feb 2017 12:03:45 +0200 Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 10:06 AM, Boris Brezillon > wrote: > > On Tue, 21 Feb 2017 01:54:37 +0200 > > Andy Shevchenko wrote: > > > >> On Tue, Feb 21, 2017 at 1:40 AM, Andy Shevchenko > >> wrote: > >> > On Mon, Feb 20, 2017 at 10:5

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Andy Shevchenko
On Tue, Feb 21, 2017 at 10:06 AM, Boris Brezillon wrote: > On Tue, 21 Feb 2017 01:54:37 +0200 > Andy Shevchenko wrote: > >> On Tue, Feb 21, 2017 at 1:40 AM, Andy Shevchenko >> wrote: >> > On Mon, Feb 20, 2017 at 10:50 PM, Boris Brezillon >> > wrote: >> >> On Mon, 20 Feb 2017 21:38:03 +0100 >> >

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-21 Thread Boris Brezillon
On Tue, 21 Feb 2017 01:54:37 +0200 Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 1:40 AM, Andy Shevchenko > wrote: > > On Mon, Feb 20, 2017 at 10:50 PM, Boris Brezillon > > wrote: > >> On Mon, 20 Feb 2017 21:38:03 +0100 > >> Boris Brezillon wrote: > >> > >>> On Mon, 20 Feb 2017 22:27:17

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-20 Thread Andy Shevchenko
On Tue, Feb 21, 2017 at 1:40 AM, Andy Shevchenko wrote: > On Mon, Feb 20, 2017 at 10:50 PM, Boris Brezillon > wrote: >> On Mon, 20 Feb 2017 21:38:03 +0100 >> Boris Brezillon wrote: >> >>> On Mon, 20 Feb 2017 22:27:17 +0200 >>> Andy Shevchenko wrote: >>> >>> > On Mon, Feb 20, 2017 at 2:28 PM, Bo

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-20 Thread Andy Shevchenko
On Mon, Feb 20, 2017 at 10:50 PM, Boris Brezillon wrote: > On Mon, 20 Feb 2017 21:38:03 +0100 > Boris Brezillon wrote: > >> On Mon, 20 Feb 2017 22:27:17 +0200 >> Andy Shevchenko wrote: >> >> > On Mon, Feb 20, 2017 at 2:28 PM, Boris Brezillon >> > wrote: >> > >> > > drivers/mtd/nand/atmel/nand-

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-20 Thread Boris Brezillon
On Mon, 20 Feb 2017 21:38:03 +0100 Boris Brezillon wrote: > On Mon, 20 Feb 2017 22:27:17 +0200 > Andy Shevchenko wrote: > > > On Mon, Feb 20, 2017 at 2:28 PM, Boris Brezillon > > wrote: > > > > > drivers/mtd/nand/atmel/nand-controller.c | 2269 > > > +++ > > > driv

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-20 Thread Boris Brezillon
On Mon, 20 Feb 2017 22:27:17 +0200 Andy Shevchenko wrote: > On Mon, Feb 20, 2017 at 2:28 PM, Boris Brezillon > wrote: > > > drivers/mtd/nand/atmel/nand-controller.c | 2269 +++ > > drivers/mtd/nand/atmel_nand.c| 2479 > > -- >

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

2017-02-20 Thread Andy Shevchenko
On Mon, Feb 20, 2017 at 2:28 PM, Boris Brezillon wrote: > drivers/mtd/nand/atmel/nand-controller.c | 2269 +++ > drivers/mtd/nand/atmel_nand.c| 2479 > -- Does -M -C help you? At least it would help reviewers -- With Best Regards