Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-12 Thread Julien Grall
On 12/11/15 18:24, Roger Pau Monné wrote: >> So if one get EOPNOTSUPP the other will get too. > > That's why I said that I think it's not currently possible. IMHO, it's > fine as it is now. > > The only scenario I can think of that can lead to that combination is > that we migrate the guest and o

Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-12 Thread Roger Pau Monné
El 12/11/15 a les 19.04, Julien Grall ha escrit: > On 12/11/15 17:51, Roger Pau Monné wrote: >> El 12/11/15 a les 18.30, Julien Grall ha escrit: >>> Hi, >>> >>> On 12/11/15 16:40, Roger Pau Monné wrote: > [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html > > Signed-

Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-12 Thread Julien Grall
On 12/11/15 17:51, Roger Pau Monné wrote: > El 12/11/15 a les 18.30, Julien Grall ha escrit: >> Hi, >> >> On 12/11/15 16:40, Roger Pau Monné wrote: [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html Signed-off-by: Julien Grall >>> >>> LGTM, only a couple of typos

Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-12 Thread Roger Pau Monné
El 12/11/15 a les 18.30, Julien Grall ha escrit: > Hi, > > On 12/11/15 16:40, Roger Pau Monné wrote: >>> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html >>> >>> Signed-off-by: Julien Grall >> >> LGTM, only a couple of typos and a simplification: >> >> Signed-off-by: Roger P

Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-12 Thread Julien Grall
Hi, On 12/11/15 16:40, Roger Pau Monné wrote: >> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html >> >> Signed-off-by: Julien Grall > > LGTM, only a couple of typos and a simplification: > > Signed-off-by: Roger Pau Monné Do you mean Acked-by? ;) >> + >> +/* The I/O

Re: [PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-12 Thread Roger Pau Monné
El 19/10/15 a les 16.19, Julien Grall ha escrit: > The minimal size of request in the block framework is always PAGE_SIZE. > It means that when 64KB guest is support, the request will at least be > 64KB. > > Although, if the backend doesn't support indirect descriptor (such as QDISK > in QEMU), a

Re: [PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-12 Thread Roger Pau Monné
El 19/10/15 a les 16.19, Julien Grall ha escrit: > The minimal size of request in the block framework is always PAGE_SIZE. > It means that when 64KB guest is support, the request will at least be > 64KB. > > Although, if the backend doesn't support indirect descriptor (such as QDISK > in QEMU), a

[PATCH v2 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-10-19 Thread Julien Grall
The minimal size of request in the block framework is always PAGE_SIZE. It means that when 64KB guest is support, the request will at least be 64KB. Although, if the backend doesn't support indirect descriptor (such as QDISK in QEMU), a ring request is only able to accommodate 11 segments of 4KB (