Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-07-07 Thread Heiko Stübner
Am Montag, 7. Juli 2014, 08:21:40 schrieb Mark Brown: > On Mon, Jul 07, 2014 at 09:08:41AM +0200, Heiko Stübner wrote: > > Am Montag, 7. Juli 2014, 09:42:52 schrieb addy ke: > > > > Your DT binding defined some additional compatible strings, please add > > > > those to the driver. > > > > citing M

Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-07-07 Thread Mark Brown
On Mon, Jul 07, 2014 at 09:08:41AM +0200, Heiko Stübner wrote: > Am Montag, 7. Juli 2014, 09:42:52 schrieb addy ke: > > > Your DT binding defined some additional compatible strings, please add > > > those to the driver. > citing Mark Rutland (one of the dt maintainers): > -- > That's why I sai

Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-07-07 Thread Mark Brown
On Mon, Jul 07, 2014 at 09:42:52AM +0800, addy ke wrote: > > The driver shouldn't be doing this, if it needs a delay it needs to > > implement it itself. delay_usecs can be set by devices if they need a > > delay between transfers, it should be in addition to the time taken for > > the transfer t

Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-07-07 Thread Heiko Stübner
Am Montag, 7. Juli 2014, 09:42:52 schrieb addy ke: > > On Tue, Jul 01, 2014 at 09:03:59AM +0800, addy ke wrote: > >> +static const struct of_device_id rockchip_spi_dt_match[] = { > >> + { .compatible = "rockchip,rk3066-spi", }, > >> + { }, > >> +}; > >> +MODULE_DEVICE_TABLE(of, rockchip_spi_dt_ma

Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-07-06 Thread addy ke
> On Tue, Jul 01, 2014 at 09:03:59AM +0800, addy ke wrote: >> In order to facilitate understanding, rockchip SPI controller IP design >> looks similar in its registers to designware. But IC implementation >> is different from designware, So we need a dedicated driver for Rockchip >> RK3XXX SoCs int

Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-07-05 Thread Jonas Gorski
On Fri, Jul 4, 2014 at 8:32 PM, Mark Brown wrote: > On Tue, Jul 01, 2014 at 09:03:59AM +0800, addy ke wrote: >> In order to facilitate understanding, rockchip SPI controller IP design >> looks similar in its registers to designware. But IC implementation >> is different from designware, So we need

Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-07-04 Thread Mark Brown
On Tue, Jul 01, 2014 at 09:03:59AM +0800, addy ke wrote: > In order to facilitate understanding, rockchip SPI controller IP design > looks similar in its registers to designware. But IC implementation > is different from designware, So we need a dedicated driver for Rockchip > RK3XXX SoCs integrate

[PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI

2014-06-30 Thread addy ke
In order to facilitate understanding, rockchip SPI controller IP design looks similar in its registers to designware. But IC implementation is different from designware, So we need a dedicated driver for Rockchip RK3XXX SoCs integrated SPI. The main differences: - dma request line: rockchip SPI co