Re: [PATCH v2 2/3] exec: Move S_ISREG() check earlier

2020-08-13 Thread Kees Cook
On Thu, Aug 13, 2020 at 03:13:05PM +0100, Marc Zyngier wrote: > On Fri, 5 Jun 2020 09:00:12 -0700 > Kees Cook wrote: > > Hi Kees, > > > The execve(2)/uselib(2) syscalls have always rejected non-regular > > files. Recently, it was noticed that a deadlock was introduced when trying > > to execute

Re: [PATCH v2 2/3] exec: Move S_ISREG() check earlier

2020-08-13 Thread Marc Zyngier
On Fri, 5 Jun 2020 09:00:12 -0700 Kees Cook wrote: Hi Kees, > The execve(2)/uselib(2) syscalls have always rejected non-regular > files. Recently, it was noticed that a deadlock was introduced when trying > to execute pipes, as the S_ISREG() test was happening too late. This was > fixed in comm

[PATCH v2 2/3] exec: Move S_ISREG() check earlier

2020-06-05 Thread Kees Cook
The execve(2)/uselib(2) syscalls have always rejected non-regular files. Recently, it was noticed that a deadlock was introduced when trying to execute pipes, as the S_ISREG() test was happening too late. This was fixed in commit 73601ea5b7b1 ("fs/open.c: allow opening only regular files during exe