Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

On 7/16/19 1:39 PM, Bartlomiej Zolnierkiewicz wrote: > > On 7/16/19 1:26 PM, Chanwoo Choi wrote: [...] >>> Doesn't seem to be needed, care to explain it more? >> >> In order to fix the sequence problem between clock and regulator >> with dev_pm_opp_set_regualtor() and want to keep two

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

On 7/16/19 1:26 PM, Chanwoo Choi wrote: > Hi, > > On 19. 7. 16. 오후 7:59, Bartlomiej Zolnierkiewicz wrote: >> >> On 7/16/19 12:33 PM, Chanwoo Choi wrote: >>> Hi Bartlomiej, >>> >>> On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: Hi Chanwoo, On 7/16/19 5:56 AM, Chanwoo

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

Hi, On 19. 7. 16. 오후 7:59, Bartlomiej Zolnierkiewicz wrote: > > On 7/16/19 12:33 PM, Chanwoo Choi wrote: >> Hi Bartlomiej, >> >> On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: >>> >>> Hi Chanwoo, >>> >>> On 7/16/19 5:56 AM, Chanwoo Choi wrote: Hi Kamil, Looks good to me.

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

On 7/16/19 12:33 PM, Chanwoo Choi wrote: > Hi Bartlomiej, > > On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: >> >> Hi Chanwoo, >> >> On 7/16/19 5:56 AM, Chanwoo Choi wrote: >>> Hi Kamil, >>> >>> Looks good to me. But, this patch has some issue. >>> I added the detailed reviews. >>> >>>

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

Hi Bartlomiej, On 19. 7. 16. 오후 7:13, Bartlomiej Zolnierkiewicz wrote: > > Hi Chanwoo, > > On 7/16/19 5:56 AM, Chanwoo Choi wrote: >> Hi Kamil, >> >> Looks good to me. But, this patch has some issue. >> I added the detailed reviews. >> >> I recommend that you make the separate patches as

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

Hi Chanwoo, On 7/16/19 5:56 AM, Chanwoo Choi wrote: > Hi Kamil, > > Looks good to me. But, this patch has some issue. > I added the detailed reviews. > > I recommend that you make the separate patches as following > in order to clarify the role of which apply the dev_pm_opp_* function. > >

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

Hi Kamil, Looks good to me. But, this patch has some issue. I added the detailed reviews. I recommend that you make the separate patches as following in order to clarify the role of which apply the dev_pm_opp_* function. First patch, Need to consolidate the following two function into one

[PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

Reuse opp core code for setting bus clock and voltage. As a side effect this allow useage of coupled regulators feature (required for boards using Exynos5422/5800 SoCs) because dev_pm_opp_set_rate() uses regulator_set_voltage_triplet() for setting regulator voltage while the old code used