Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Hein Tibosch
On 6/12/2013 5:00 PM, Andy Shevchenko wrote: > [+ Hein] > > On Wed, 2013-06-12 at 13:42 +0530, Vinod Koul wrote: >> On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: >>> On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul wrote: On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Arnd Bergmann
On Wednesday 12 June 2013 14:32:02 Vinod Koul wrote: > config DW_DMAC > tristate "Synopsys DesignWare AHB DMA platform driver" > select DW_DMAC_CORE > + select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 > default y if CPU_AT32AP7000 > help > Support the

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 14:32, Vinod Koul wrote: > diff --git a/drivers/dma/dw/regs.h b/drivers/dma/dw/regs.h > index 07c5a6e..deb4274 100644 > --- a/drivers/dma/dw/regs.h > +++ b/drivers/dma/dw/regs.h > @@ -101,6 +101,12 @@ struct dw_dma_regs { > u32 DW_PARAMS; > }; > > +/* > + * Big endian

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 12:07:24PM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2013 at 11:19 AM, Vinod Koul wrote: > > On Wed, Jun 12, 2013 at 02:23:39PM +0530, Viresh Kumar wrote: > >> On 12 June 2013 13:42, Vinod Koul wrote: > >> > >> > Never mind, am applying your patches and below fix,

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 11:19 AM, Vinod Koul wrote: > On Wed, Jun 12, 2013 at 02:23:39PM +0530, Viresh Kumar wrote: >> On 12 June 2013 13:42, Vinod Koul wrote: >> >> > Never mind, am applying your patches and below fix, let me if you guys are >> > okay >> >> I am not :) I >> >> > diff --git

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 13:49, Vinod Koul wrote: > Well now the config option is not selected by users, so they dont need to > know. > It was useful in knowing what to select earlier I am concerned about driver writers rather than end users as this is fixed for a driver. And yes its better we don't

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
[+ Hein] On Wed, 2013-06-12 at 13:42 +0530, Vinod Koul wrote: > On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: > > On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul wrote: > > > On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: > > >> On Wed, Jun 12, 2013 at 10:39

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 02:23:39PM +0530, Viresh Kumar wrote: > On 12 June 2013 13:42, Vinod Koul wrote: > > > Never mind, am applying your patches and below fix, let me if you guys are > > okay > > I am not :) > > > diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig > > index

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 13:42, Vinod Koul wrote: > Never mind, am applying your patches and below fix, let me if you guys are > okay I am not :) > diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig > index db2b41f..7be1cf8 100644 > --- a/drivers/dma/dw/Kconfig > +++ b/drivers/dma/dw/Kconfig

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul wrote: > > On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: > >> On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul wrote: > >> > >> [] > >> > >> > Something like > >> >

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul wrote: > On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: >> On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul wrote: >> >> [] >> >> > Something like >> > config DW_DMAC_BIG_ENDIAN_IO >> > tristate >> > >> > config DW_DMAC >> >

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul wrote: > > On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote: > >> On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul wrote: > >> > On Wed, Jun 05, 2013 at 03:26:44PM +0300,

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul wrote: > On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote: >> On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul wrote: >> > On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: [] > Something like > config DW_DMAC_BIG_ENDIAN_IO

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 13:08, Vinod Koul wrote: > Something like > config DW_DMAC_BIG_ENDIAN_IO > tristate > > config DW_DMAC > select DW_DMAC_BIG_ENDIAN_IO > > I belive DW_DMAC is for AVR support and the PCI ones is different right. No. DW_DMAC is for ARM as well. -- To unsubscribe

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul wrote: > > On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: > >> The dw_dmac driver is going to be split into multiple files. To make this > >> more > >> convenient move

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul wrote: > On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: >> The dw_dmac driver is going to be split into multiple files. To make this >> more >> convenient move it to an own directory. >> >> Signed-off-by: Andy Shevchenko >> Acked-by:

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: The dw_dmac driver is going to be split into multiple files. To make this more convenient move it to an own directory. Signed-off-by: Andy Shevchenko

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: The dw_dmac driver is going to be split into multiple files. To make this more

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 13:08, Vinod Koul vinod.k...@intel.com wrote: Something like config DW_DMAC_BIG_ENDIAN_IO tristate config DW_DMAC select DW_DMAC_BIG_ENDIAN_IO I belive DW_DMAC is for AVR support and the PCI ones is different right. No. DW_DMAC is for ARM as well. -- To

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: [] Something

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 05,

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul vinod.k...@intel.com wrote: [] Something like config DW_DMAC_BIG_ENDIAN_IO tristate config

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul vinod.k...@intel.com wrote: []

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 13:42, Vinod Koul vinod.k...@intel.com wrote: Never mind, am applying your patches and below fix, let me if you guys are okay I am not :) diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig index db2b41f..7be1cf8 100644 --- a/drivers/dma/dw/Kconfig +++

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 02:23:39PM +0530, Viresh Kumar wrote: On 12 June 2013 13:42, Vinod Koul vinod.k...@intel.com wrote: Never mind, am applying your patches and below fix, let me if you guys are okay I am not :) diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
[+ Hein] On Wed, 2013-06-12 at 13:42 +0530, Vinod Koul wrote: On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 13:49, Vinod Koul vinod.k...@intel.com wrote: Well now the config option is not selected by users, so they dont need to know. It was useful in knowing what to select earlier I am concerned about driver writers rather than end users as this is fixed for a driver. And yes its

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Andy Shevchenko
On Wed, Jun 12, 2013 at 11:19 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 02:23:39PM +0530, Viresh Kumar wrote: On 12 June 2013 13:42, Vinod Koul vinod.k...@intel.com wrote: Never mind, am applying your patches and below fix, let me if you guys are okay I am not :)

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 12:07:24PM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 11:19 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 02:23:39PM +0530, Viresh Kumar wrote: On 12 June 2013 13:42, Vinod Koul vinod.k...@intel.com wrote: Never mind, am applying

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Viresh Kumar
On 12 June 2013 14:32, Vinod Koul vinod.k...@intel.com wrote: diff --git a/drivers/dma/dw/regs.h b/drivers/dma/dw/regs.h index 07c5a6e..deb4274 100644 --- a/drivers/dma/dw/regs.h +++ b/drivers/dma/dw/regs.h @@ -101,6 +101,12 @@ struct dw_dma_regs { u32 DW_PARAMS; }; +/* + *

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Arnd Bergmann
On Wednesday 12 June 2013 14:32:02 Vinod Koul wrote: config DW_DMAC tristate Synopsys DesignWare AHB DMA platform driver select DW_DMAC_CORE + select DW_DMAC_BIG_ENDIAN_IO if ARCH=AVR32 default y if CPU_AT32AP7000 help Support the Synopsys

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-12 Thread Hein Tibosch
On 6/12/2013 5:00 PM, Andy Shevchenko wrote: [+ Hein] On Wed, 2013-06-12 at 13:42 +0530, Vinod Koul wrote: On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote: On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-11 Thread Vinod Koul
On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: > The dw_dmac driver is going to be split into multiple files. To make this more > convenient move it to an own directory. > > Signed-off-by: Andy Shevchenko > Acked-by: Viresh Kumar > Acked-by: Arnd Bergmann > --- > +config

Re: [PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-11 Thread Vinod Koul
On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote: The dw_dmac driver is going to be split into multiple files. To make this more convenient move it to an own directory. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar

[PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-05 Thread Andy Shevchenko
The dw_dmac driver is going to be split into multiple files. To make this more convenient move it to an own directory. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar Acked-by: Arnd Bergmann --- MAINTAINERS | 3 +-- drivers/dma/Kconfig | 20

[PATCH v2 2/4] dma: move dw_dmac driver to an own directory

2013-06-05 Thread Andy Shevchenko
The dw_dmac driver is going to be split into multiple files. To make this more convenient move it to an own directory. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Arnd Bergmann a...@arndb.de --- MAINTAINERS