Re: [PATCH v2 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-20 Thread Russell King - ARM Linux admin
On Thu, Jun 20, 2019 at 05:56:32AM +, Parshuram Raju Thombare wrote: > For in band mode, I see two places to config MAC speed > and duplex mode, 1. mac_link_state 2. mac_link_up. In mac_link_up, though > state > read from mac_link_state is passed, it is only used for printing log and > updati

RE: [PATCH v2 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-19 Thread Parshuram Raju Thombare
>From: Russell King - ARM Linux admin > >On Wed, Jun 19, 2019 at 11:23:01AM +, Parshuram Raju Thombare wrote: > >> >From: Russell King - ARM Linux admin > >> > > >> >On Wed, Jun 19, 2019 at 09:40:46AM +0100, Parshuram Thombare wrote: > >> > > >> >> This patch add support for SGMII interface)

Re: [PATCH v2 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-19 Thread Russell King - ARM Linux admin
On Wed, Jun 19, 2019 at 11:23:01AM +, Parshuram Raju Thombare wrote: > >From: Russell King - ARM Linux admin > > > >On Wed, Jun 19, 2019 at 09:40:46AM +0100, Parshuram Thombare wrote: > > > >> This patch add support for SGMII interface) and > > > >> 2.5Gbps MAC in Cadence ethernet controller d

RE: [PATCH v2 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-19 Thread Parshuram Raju Thombare
>From: Russell King - ARM Linux admin > >On Wed, Jun 19, 2019 at 09:40:46AM +0100, Parshuram Thombare wrote: > >> This patch add support for SGMII interface) and > >> 2.5Gbps MAC in Cadence ethernet controller driver. >> switch (state->interface) { > >> +case PHY_INTERFACE_MODE_SGMII: >

Re: [PATCH v2 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-19 Thread Russell King - ARM Linux admin
On Wed, Jun 19, 2019 at 09:40:46AM +0100, Parshuram Thombare wrote: > This patch add support for SGMII interface) and > 2.5Gbps MAC in Cadence ethernet controller driver. > > Signed-off-by: Parshuram Thombare > --- > drivers/net/ethernet/cadence/macb.h | 76 ++-- > drivers/net/ethe

[PATCH v2 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-19 Thread Parshuram Thombare
This patch add support for SGMII interface) and 2.5Gbps MAC in Cadence ethernet controller driver. Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/macb.h | 76 ++-- drivers/net/ethernet/cadence/macb_main.c | 151 --- 2 files changed, 200 inser