> > First register the handler, then activate interrupts. You are right,
> > this needs to be fixed, too.
>
> Do you want me to create separate patch just about moving request irq in
> front of
> xiic_reinit()? And then devm_ conversion?
Yes, seperate, please.
signature.asc
Description: Digi
On 10/04/2013 01:58 PM, Wolfram Sang wrote:
> On Fri, Oct 04, 2013 at 11:16:20AM +0200, Michal Simek wrote:
>> On 10/04/2013 07:33 AM, Wolfram Sang wrote:
>>>
+ i2c->base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(i2c->base)) {
+ dev_err(&pdev->dev, "Could not
On Fri, Oct 04, 2013 at 11:16:20AM +0200, Michal Simek wrote:
> On 10/04/2013 07:33 AM, Wolfram Sang wrote:
> >
> >> + i2c->base = devm_ioremap_resource(&pdev->dev, res);
> >> + if (IS_ERR(i2c->base)) {
> >> + dev_err(&pdev->dev, "Could not allocate iomem\n");
> >
> > devm_ioremap_reso
On 10/04/2013 07:33 AM, Wolfram Sang wrote:
>
>> +i2c->base = devm_ioremap_resource(&pdev->dev, res);
>> +if (IS_ERR(i2c->base)) {
>> +dev_err(&pdev->dev, "Could not allocate iomem\n");
>
> devm_ioremap_resource already prints error messages.
you are right.
>
>> +ret =
> + i2c->base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(i2c->base)) {
> + dev_err(&pdev->dev, "Could not allocate iomem\n");
devm_ioremap_resource already prints error messages.
> + ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c);
Thi
From: Kedareswara rao Appana
Simplified the probe and remove functions using devm_* functions
Signed-off-by: Kedareswara rao Appana
Signed-off-by: Michal Simek
---
Changes in v2: None
drivers/i2c/busses/i2c-xiic.c | 69 +++
1 file changed, 18 insertion
6 matches
Mail list logo
