Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-08-14 Thread Lee Jones
On Fri, 14 Aug 2015, Jassi Brar wrote: > On Fri, Aug 14, 2015 at 12:03 PM, Lee Jones wrote: > > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > >> > >> > + > >> > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) > >> > +{ > >> > + st

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-08-14 Thread Jassi Brar
On Fri, Aug 14, 2015 at 12:03 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> >> > + >> > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) >> > +{ >> > + struct sti_channel *chan_info = chan->con_priv; >> > +

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: > On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > > > + > > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) > > +{ > > + struct sti_channel *chan_info = chan->con_priv; > > + struct sti_mbox_device *mdev = chan_info->mdev; > > +

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-08-13 Thread Jassi Brar
On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > + > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) > +{ > + struct sti_channel *chan_info = chan->con_priv; > + struct sti_mbox_device *mdev = chan_info->mdev; > + unsigned int instance = chan_info->instance; > +

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-30 Thread Lee Jones
On Thu, 30 Jul 2015, Paul Bolle wrote: > On do, 2015-07-30 at 12:45 +0100, Lee Jones wrote: > > On Wed, 29 Jul 2015, Paul Bolle wrote: > > > Besides, if I read sti_max_probe() correctly, without OF support > > > loading > > > this module won't accomplish much. So what would another way of > > > au

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-30 Thread Paul Bolle
On do, 2015-07-30 at 12:45 +0100, Lee Jones wrote: > On Wed, 29 Jul 2015, Paul Bolle wrote: > > Besides, if I read sti_max_probe() correctly, without OF support > > loading > > this module won't accomplish much. So what would another way of > > autoloading this module buy you? > > I think this lin

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-30 Thread Lee Jones
On Wed, 29 Jul 2015, Paul Bolle wrote: > On ma, 2015-07-27 at 10:44 +0100, Lee Jones wrote: > > --- /dev/null > > +++ b/drivers/mailbox/mailbox-sti.c > > > +static int sti_mbox_probe(struct platform_device *pdev) > > +{ > > + [...] > > + > > + match = of_match_device(sti_mailbox_match, &pdev-

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-28 Thread Paul Bolle
On ma, 2015-07-27 at 10:44 +0100, Lee Jones wrote: > --- /dev/null > +++ b/drivers/mailbox/mailbox-sti.c > +static int sti_mbox_probe(struct platform_device *pdev) > +{ > + [...] > + > + match = of_match_device(sti_mailbox_match, &pdev->dev); > + if (!match) { > + dev_err(&

[PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

2015-07-27 Thread Lee Jones
ST's platforms currently support a maximum of 5 Mailboxes, one for each of the supported co-processors situated on the platform. Each Mailbox is divided up into 4 instances which consist of 32 channels. Messages are passed between the application and co-processors using shared memory areas. It is