Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-23 Thread Lee Jones
On Mon, 16 Jan 2017, Javier Martinez Canillas wrote: > Hello Chanwoo, > > Thanks for the review. > > On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > > Hi, > > > > I think that this patch better to squash with patch3. > > After applying the patch3, this driver doesn't use > > the max77686_i2c_id

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-23 Thread Lee Jones
On Mon, 16 Jan 2017, Javier Martinez Canillas wrote: > Hello Chanwoo, > > Thanks for the review. > > On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > > Hi, > > > > I think that this patch better to squash with patch3. > > After applying the patch3, this driver doesn't use > > the max77686_i2c_id

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-23 Thread Lee Jones
On Fri, 13 Jan 2017, Javier Martinez Canillas wrote: > The driver is only used in DT platforms so there's no need to > have an i2c_device_id table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > Reviewed-by: Krzysztof

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-23 Thread Lee Jones
On Fri, 13 Jan 2017, Javier Martinez Canillas wrote: > The driver is only used in DT platforms so there's no need to > have an i2c_device_id table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > >

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-16 Thread Javier Martinez Canillas
Hello Chanwoo, Thanks for the review. On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > Hi, > > I think that this patch better to squash with patch3. > After applying the patch3, this driver doesn't use > the max77686_i2c_id table. > I usually prefer to separate each change in a different patch,

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-16 Thread Javier Martinez Canillas
Hello Chanwoo, Thanks for the review. On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > Hi, > > I think that this patch better to squash with patch3. > After applying the patch3, this driver doesn't use > the max77686_i2c_id table. > I usually prefer to separate each change in a different patch,

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-15 Thread Chanwoo Choi
Hi, I think that this patch better to squash with patch3. After applying the patch3, this driver doesn't use the max77686_i2c_id table. On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > The driver is only used in DT platforms so there's no need to > have an i2c_device_id table. > >

Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-15 Thread Chanwoo Choi
Hi, I think that this patch better to squash with patch3. After applying the patch3, this driver doesn't use the max77686_i2c_id table. On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > The driver is only used in DT platforms so there's no need to > have an i2c_device_id table. > >

[PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-13 Thread Javier Martinez Canillas
The driver is only used in DT platforms so there's no need to have an i2c_device_id table. Signed-off-by: Javier Martinez Canillas Acked-by: Laxman Dewangan Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski

[PATCH v2 4/4] mfd: max77686: Remove I2C device ID table

2017-01-13 Thread Javier Martinez Canillas
The driver is only used in DT platforms so there's no need to have an i2c_device_id table. Signed-off-by: Javier Martinez Canillas Acked-by: Laxman Dewangan Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski --- Changes in v2: - Add Laxman's Acked-by tag to patch 4/4. - Add