Re: [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL

Quoting Vinod Koul (2020-12-10 21:02:57) > On 10-12-20, 12:36, Stephen Boyd wrote: > > > + > > > + return regmap_update_bits(pll->clkr.regmap, PLL_USER_CTL(pll), > > > + (BIT(pll->width) - 1) << > > > pll->post_div_shift, > > > > Use GENMASK? > > Looks like

Re: [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL

On 10-12-20, 12:36, Stephen Boyd wrote: > Quoting Vinod Koul (2020-12-07 22:47:01) > > diff --git a/drivers/clk/qcom/clk-alpha-pll.c > > b/drivers/clk/qcom/clk-alpha-pll.c > > index 564431130a76..6a399663d564 100644 > > --- a/drivers/clk/qcom/clk-alpha-pll.c > > +++

Re: [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL

Quoting Vinod Koul (2020-12-07 22:47:01) > diff --git a/drivers/clk/qcom/clk-alpha-pll.c > b/drivers/clk/qcom/clk-alpha-pll.c > index 564431130a76..6a399663d564 100644 > --- a/drivers/clk/qcom/clk-alpha-pll.c > +++ b/drivers/clk/qcom/clk-alpha-pll.c > @@ -146,6 +146,12 @@

[PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Lucid 5LPE PLL

From: Vivek Aknurwar Lucid 5LPE is a slightly different Lucid PLL with different offsets and porgramming sequence so add support for these Signed-off-by: Vivek Aknurwar Signed-off-by: Jeevan Shriram [vkoul: rebase and tidy up for upstream] Signed-off-by: Vinod Koul ---