Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-24 Thread Cory Tusar
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/19/2015 01:05 AM, Vladimir Zapolskiy wrote: > On 19.11.2015 05:29, Cory Tusar wrote: >> This commit adds support to the eeprom_93x46 driver allowing a GPIO line >> to function as a 'select' or 'enable' signal prior to accessing the >> EEPROM. >>

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-24 Thread Cory Tusar
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/19/2015 01:05 AM, Vladimir Zapolskiy wrote: > On 19.11.2015 05:29, Cory Tusar wrote: >> This commit adds support to the eeprom_93x46 driver allowing a GPIO line >> to function as a 'select' or 'enable' signal prior to accessing the >> EEPROM. >>

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-19 Thread Andrew Lunn
On Thu, Nov 19, 2015 at 06:52:57PM +0200, Vladimir Zapolskiy wrote: > On 19.11.2015 16:18, Andrew Lunn wrote: > >>> #ifdef CONFIG_OF > >>> +static void select_assert(void *context) > >>> +{ > >>> + struct eeprom_93xx46_dev *edev = context; > >>> + > >>> +

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-19 Thread Vladimir Zapolskiy
On 19.11.2015 16:18, Andrew Lunn wrote: >>> #ifdef CONFIG_OF >>> +static void select_assert(void *context) >>> +{ >>> + struct eeprom_93xx46_dev *edev = context; >>> + >>> + gpiod_set_value_cansleep(gpio_to_desc(edev->pdata->select_gpio), 1); >> >> I would suggest to use gpio_set_value() > >

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-19 Thread Andrew Lunn
> > #ifdef CONFIG_OF > > +static void select_assert(void *context) > > +{ > > + struct eeprom_93xx46_dev *edev = context; > > + > > + gpiod_set_value_cansleep(gpio_to_desc(edev->pdata->select_gpio), 1); > > I would suggest to use gpio_set_value() Could you explain why? Maybe this gpio is

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-19 Thread Vladimir Zapolskiy
On 19.11.2015 16:18, Andrew Lunn wrote: >>> #ifdef CONFIG_OF >>> +static void select_assert(void *context) >>> +{ >>> + struct eeprom_93xx46_dev *edev = context; >>> + >>> + gpiod_set_value_cansleep(gpio_to_desc(edev->pdata->select_gpio), 1); >> >> I would suggest to use gpio_set_value() > >

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-19 Thread Andrew Lunn
On Thu, Nov 19, 2015 at 06:52:57PM +0200, Vladimir Zapolskiy wrote: > On 19.11.2015 16:18, Andrew Lunn wrote: > >>> #ifdef CONFIG_OF > >>> +static void select_assert(void *context) > >>> +{ > >>> + struct eeprom_93xx46_dev *edev = context; > >>> + > >>> +

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-19 Thread Andrew Lunn
> > #ifdef CONFIG_OF > > +static void select_assert(void *context) > > +{ > > + struct eeprom_93xx46_dev *edev = context; > > + > > + gpiod_set_value_cansleep(gpio_to_desc(edev->pdata->select_gpio), 1); > > I would suggest to use gpio_set_value() Could you explain why? Maybe this gpio is

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-18 Thread Vladimir Zapolskiy
On 19.11.2015 05:29, Cory Tusar wrote: > This commit adds support to the eeprom_93x46 driver allowing a GPIO line > to function as a 'select' or 'enable' signal prior to accessing the > EEPROM. > > Signed-off-by: Cory Tusar > --- > drivers/misc/eeprom/eeprom_93xx46.c | 26

[PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-18 Thread Cory Tusar
This commit adds support to the eeprom_93x46 driver allowing a GPIO line to function as a 'select' or 'enable' signal prior to accessing the EEPROM. Signed-off-by: Cory Tusar --- drivers/misc/eeprom/eeprom_93xx46.c | 26 ++ include/linux/eeprom_93xx46.h | 1 + 2

Re: [PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-18 Thread Vladimir Zapolskiy
On 19.11.2015 05:29, Cory Tusar wrote: > This commit adds support to the eeprom_93x46 driver allowing a GPIO line > to function as a 'select' or 'enable' signal prior to accessing the > EEPROM. > > Signed-off-by: Cory Tusar > --- >

[PATCH v2 5/5] misc: eeprom_93xx46: Add support for a GPIO 'select' line.

2015-11-18 Thread Cory Tusar
This commit adds support to the eeprom_93x46 driver allowing a GPIO line to function as a 'select' or 'enable' signal prior to accessing the EEPROM. Signed-off-by: Cory Tusar --- drivers/misc/eeprom/eeprom_93xx46.c | 26 ++