Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: > On Thu, Aug 13, 2015 at 6:37 PM, Lee Jones wrote: > > > > Now just agree with me that mbox_request_chan() should fail on request > > of a known bad configuration request and I can code all this up and > > re-submit. :D > > > You make me look like a jerk

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 6:37 PM, Lee Jones wrote: > > Now just agree with me that mbox_request_chan() should fail on request > of a known bad configuration request and I can code all this up and > re-submit. :D > You make me look like a jerk :( My problem is not with validation as such. I see

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: > On Thu, Aug 13, 2015 at 5:10 PM, Lee Jones wrote: > > On Thu, 13 Aug 2015, Jassi Brar wrote: > > > >> On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: > >> > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> > > >> >> On Thu, Aug 13, 2015 at 3:53 PM, Lee

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 5:10 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> > >> >> On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: >> >> > On Thu, 13 Aug 2015, Jassi Brar

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: > On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: > > On Thu, 13 Aug 2015, Jassi Brar wrote: > > > >> On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: > >> > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> > > >> >> On Thu, Aug 13, 2015 at 2:49 PM, Lee

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> > >> >> On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: >> >> > On Thu, 13 Aug 2015, Jassi Brar

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: > On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: > > On Thu, 13 Aug 2015, Jassi Brar wrote: > > > >> On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: > >> > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> > >> >> >> > + > >> >> >> > +static void

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> >> >> >> > + >> >> >> > +static void mbox_test_prepare_message(struct mbox_client *client, >> >> >> >

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: > On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: > > On Thu, 13 Aug 2015, Jassi Brar wrote: > > >> >> > + > >> >> > +static void mbox_test_prepare_message(struct mbox_client *client, > >> >> > void *message) > >> >> > +{ > >> >> > + struct

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: >> >> > + >> >> > +static void mbox_test_prepare_message(struct mbox_client *client, void >> >> > *message) >> >> > +{ >> >> > + struct mbox_test_device *tdev = dev_get_drvdata(client->dev); >> >> >

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: > On Wed, Aug 12, 2015 at 3:53 PM, Lee Jones wrote: > > On Mon, 10 Aug 2015, Jassi Brar wrote: > > > >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > >> > This particular Client implementation uses shared memory in order > >> > to pass messages

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Wed, Aug 12, 2015 at 3:53 PM, Lee Jones wrote: > On Mon, 10 Aug 2015, Jassi Brar wrote: > >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> > This particular Client implementation uses shared memory in order >> > to pass messages between Mailbox users; however, it can be easily >> >

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Wed, Aug 12, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 10 Aug 2015, Jassi Brar wrote: On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This particular Client implementation uses shared memory in order to pass messages between Mailbox users;

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: On Wed, Aug 12, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 10 Aug 2015, Jassi Brar wrote: On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This particular Client implementation uses shared memory in order

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: + +static void

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: + +static void mbox_test_prepare_message(struct mbox_client *client, void *message) +{ + struct mbox_test_device

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: + +static void mbox_test_prepare_message(struct mbox_client *client, void *message) +{ + struct mbox_test_device *tdev = dev_get_drvdata(client-dev); + +

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: + +static void mbox_test_prepare_message(struct mbox_client

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 5:10 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 5:10 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Lee Jones
On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 6:37 PM, Lee Jones lee.jo...@linaro.org wrote: Now just agree with me that mbox_request_chan() should fail on request of a known bad configuration request and I can code all this up and re-submit. :D You make me look like

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-13 Thread Jassi Brar
On Thu, Aug 13, 2015 at 6:37 PM, Lee Jones lee.jo...@linaro.org wrote: Now just agree with me that mbox_request_chan() should fail on request of a known bad configuration request and I can code all this up and re-submit. :D You make me look like a jerk :( My problem is not with validation

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-12 Thread Lee Jones
On Mon, 10 Aug 2015, Jassi Brar wrote: > On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > > This particular Client implementation uses shared memory in order > > to pass messages between Mailbox users; however, it can be easily > > hacked to support any type of Controller. > > > >

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-12 Thread Lee Jones
On Mon, 10 Aug 2015, Jassi Brar wrote: On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This particular Client implementation uses shared memory in order to pass messages between Mailbox users; however, it can be easily hacked to support any type of Controller.

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-10 Thread Jassi Brar
On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > This particular Client implementation uses shared memory in order > to pass messages between Mailbox users; however, it can be easily > hacked to support any type of Controller. > > Signed-off-by: Lee Jones > --- > drivers/mailbox/Kconfig

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-08-10 Thread Jassi Brar
On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This particular Client implementation uses shared memory in order to pass messages between Mailbox users; however, it can be easily hacked to support any type of Controller. Signed-off-by: Lee Jones lee.jo...@linaro.org

[PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-07-27 Thread Lee Jones
This particular Client implementation uses shared memory in order to pass messages between Mailbox users; however, it can be easily hacked to support any type of Controller. Signed-off-by: Lee Jones --- drivers/mailbox/Kconfig| 7 ++ drivers/mailbox/Makefile | 2 +

[PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

2015-07-27 Thread Lee Jones
This particular Client implementation uses shared memory in order to pass messages between Mailbox users; however, it can be easily hacked to support any type of Controller. Signed-off-by: Lee Jones lee.jo...@linaro.org --- drivers/mailbox/Kconfig| 7 ++ drivers/mailbox/Makefile