RE: [PATCH v2 net-next] r8169:add support for RTL8168EP

2014-10-06 Thread Hau
> -Original Message- > From: Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Tuesday, October 07, 2014 6:13 AM > To: Hau > Cc: net...@vger.kernel.org; nic_swsd; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 net-next] r8169:add support for

Re: [PATCH v2 net-next] r8169:add support for RTL8168EP

2014-10-06 Thread Francois Romieu
Hau : [...] > Do you mean I should collect similar hardware parameters setting into one > function ? or I should set hardware parameters according to hardware > feature support version? static void r8168dp_ocp_write(...) [...] static void r8168ep_ocp_write(...) [...] static void ocp_write(...)

RE: [PATCH v2 net-next] r8169:add support for RTL8168EP

2014-10-06 Thread Hau
> -Original Message- > From: Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Saturday, October 04, 2014 4:33 AM > To: Hau > Cc: net...@vger.kernel.org; nic_swsd; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 net-next] r8169:add support for RTL8168EP

Re: [PATCH v2 net-next] r8169:add support for RTL8168EP

2014-10-03 Thread Francois Romieu
Chun-Hao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 54476ba..3efdf4d 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -1276,6 +1273,52 @@ static void rtl_w0w1_eri(struc

[PATCH v2 net-next] r8169:add support for RTL8168EP

2014-10-03 Thread Chun-Hao Lin
RTL8168EP is Realtek PCIe Gigabit Ethernet controller. It is a successor chip of RTL8168DP. For RTL8168EP, the read/write ocp register is via eri channel type 2, so I modify ocp_read() ocp_write() and move related functions under rtl_eri_read() rtl_eri_write(). The way of checking if dash is enab