Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-06-04 Thread Arnd Bergmann
On Tuesday 04 June 2013 16:12:24 Alexandre Belloni wrote: > On 04/06/2013 15:49, Nicolas Ferre wrote: > > > > ... simply use this "IS_BUILTIN(CONFIG_PHYLIB)" here -^ > > (and not above as suggested by Arnd). > > > > Jean-Christophe, Alexandre: do you agree with this conclusion? > > > >

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-06-04 Thread Alexandre Belloni
On 04/06/2013 15:49, Nicolas Ferre wrote: > > ... simply use this "IS_BUILTIN(CONFIG_PHYLIB)" here -^ > (and not above as suggested by Arnd). > > Jean-Christophe, Alexandre: do you agree with this conclusion? > > I plan to stack this patch for next at91-fixes batch. > Yeah, I prepared

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-06-04 Thread Nicolas Ferre
On 27/05/2013 14:42, Arnd Bergmann : On Monday 27 May 2013 14:05:13 Nicolas Ferre wrote: On 27/05/2013 12:48, Alexandre Belloni : A v3 is not needed simply for this. Thanks, anyway! One question though: why not just add select PHYLIB In Kconfig entry: config MACH_SAMA5_DT ? (n

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Alexandre Belloni
On 27/05/2013 14:59, Jean-Christophe PLAGNIOL-VILLARD wrote: > > no will not as you do ifdef CONFIG_PHYLIB and if CONFIG_PHYLIB=m the macro is > defended > > we do this all the time in the kernel > > I add the IS_BUILTIN & co to be used when a simple inline is not sufficient Ok, it took me a whil

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Jean-Christophe PLAGNIOL-VILLARD
On May 27, 2013, at 8:50 PM, Alexandre Belloni wrote: > On 27/05/2013 13:26, Jean-Christophe PLAGNIOL-VILLARD wrote: >> On May 27, 2013, at 6:48 PM, Alexandre Belloni >> wrote: >> >>> Fixes: >>> arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': >>> :(.text+0x1174): undefined

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Jean-Christophe PLAGNIOL-VILLARD
On May 27, 2013, at 8:05 PM, Nicolas Ferre wrote: > On 27/05/2013 12:48, Alexandre Belloni : >> Fixes: >> arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': >> :(.text+0x1174): undefined reference to `mdiobus_write' >> :(.text+0x1188): undefined reference to `mdiobus_write' >> :(.

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Alexandre Belloni
On 27/05/2013 13:26, Jean-Christophe PLAGNIOL-VILLARD wrote: > On May 27, 2013, at 6:48 PM, Alexandre Belloni > wrote: > >> Fixes: >> arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': >> :(.text+0x1174): undefined reference to `mdiobus_write' >> :(.text+0x1188): undefined referenc

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Alexandre Belloni
On 27/05/2013 14:05, Nicolas Ferre wrote: > On 27/05/2013 12:48, Alexandre Belloni : >> Fixes: >> arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': >> :(.text+0x1174): undefined reference to `mdiobus_write' >> :(.text+0x1188): undefined reference to `mdiobus_write' >> :(.text+0x119c

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Arnd Bergmann
On Monday 27 May 2013 14:05:13 Nicolas Ferre wrote: > On 27/05/2013 12:48, Alexandre Belloni : > A v3 is not needed simply for this. Thanks, anyway! > > One question though: why not just add > > select PHYLIB > > In Kconfig entry: > > config MACH_SAMA5_DT > > ? > > (note that I lik

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Nicolas Ferre
On 27/05/2013 12:48, Alexandre Belloni : Fixes: arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': :(.text+0x1174): undefined reference to `mdiobus_write' :(.text+0x1188): undefined reference to `mdiobus_write' :(.text+0x119c): undefined reference to `mdiobus_write' :(.text+0x11b0)

Re: [PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Jean-Christophe PLAGNIOL-VILLARD
On May 27, 2013, at 6:48 PM, Alexandre Belloni wrote: > Fixes: > arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': > :(.text+0x1174): undefined reference to `mdiobus_write' > :(.text+0x1188): undefined reference to `mdiobus_write' > :(.text+0x119c): undefined reference to `mdiob

[PATCH v3] ARM: at91: Fix link breakage when !CONFIG_PHYLIB

2013-05-27 Thread Alexandre Belloni
Fixes: arch/arm/mach-at91/built-in.o: In function `ksz9021rn_phy_fixup': :(.text+0x1174): undefined reference to `mdiobus_write' :(.text+0x1188): undefined reference to `mdiobus_write' :(.text+0x119c): undefined reference to `mdiobus_write' :(.text+0x11b0): undefined reference to `mdiobus_write' ar