On Wed, Dec 09, 2020 at 09:34:06AM +0800, Chao Yu wrote:
> On 2020/12/9 7:55, Jaegeuk Kim wrote:
> > On 12/07, Eric Biggers wrote:
> > > On Tue, Dec 08, 2020 at 08:51:45AM +0900, Daeho Jeong wrote:
> > > > > I am trying to review this but it is very hard, as the f2fs
> > > > > compression code is
On 2020/12/9 7:55, Jaegeuk Kim wrote:
On 12/07, Eric Biggers wrote:
On Tue, Dec 08, 2020 at 08:51:45AM +0900, Daeho Jeong wrote:
I am trying to review this but it is very hard, as the f2fs compression code is
very hard to understand.
It looks like a 'struct decompress_io_ctx' represents the wo
On 12/07, Eric Biggers wrote:
> On Tue, Dec 08, 2020 at 08:51:45AM +0900, Daeho Jeong wrote:
> > > I am trying to review this but it is very hard, as the f2fs compression
> > > code is
> > > very hard to understand.
> > >
> > > It looks like a 'struct decompress_io_ctx' represents the work to
> >
On Tue, Dec 08, 2020 at 08:51:45AM +0900, Daeho Jeong wrote:
> > I am trying to review this but it is very hard, as the f2fs compression
> > code is
> > very hard to understand.
> >
> > It looks like a 'struct decompress_io_ctx' represents the work to
> > decompress a
> > particular cluster. Sin
Chao, Jaegeuk,
Thanks. I'll update it as your comments. :)
Eric,
Decompression and verity can be executed in different thread contexts
in different timing, so we need separate counts for each.
We already use STEP_VERITY for non-compression case, so I think using
this flag in here looks more mak
On Sat, Dec 05, 2020 at 01:26:26PM +0900, Daeho Jeong wrote:
> From: Daeho Jeong
>
> I found out f2fs_free_dic() is invoked in a wrong timing, but
> f2fs_verify_bio() still needed the dic info and it triggered the
> below kernel panic. It has been caused by the race condition of
> pending_pages v
On 12/07, Chao Yu wrote:
> On 2020/12/7 15:28, Daeho Jeong wrote:
> > > It looks like it will be better to move this into merge condition?
> > >
> > > if (bio && (!page_is_mergeable(sbi, bio,
> > > *last_block_in_bio, blkaddr) ||
> > >
On 2020/12/7 15:28, Daeho Jeong wrote:
It looks like it will be better to move this into merge condition?
if (bio && (!page_is_mergeable(sbi, bio,
*last_block_in_bio, blkaddr) ||
!f2fs_crypt_mergeable_bio(bio, inode,
> It looks like it will be better to move this into merge condition?
>
> if (bio && (!page_is_mergeable(sbi, bio,
> *last_block_in_bio, blkaddr) ||
> !f2fs_crypt_mergeable_bio(bio, inode, page->index, NULL)
> ||
>
On 2020/12/5 12:26, Daeho Jeong wrote:
From: Daeho Jeong
I found out f2fs_free_dic() is invoked in a wrong timing, but
f2fs_verify_bio() still needed the dic info and it triggered the
below kernel panic. It has been caused by the race condition of
pending_pages value between decompression and v
From: Daeho Jeong
I found out f2fs_free_dic() is invoked in a wrong timing, but
f2fs_verify_bio() still needed the dic info and it triggered the
below kernel panic. It has been caused by the race condition of
pending_pages value between decompression and verity logic, when
the same compression cl
11 matches
Mail list logo
