On 25-Jan-17 20:45, Wolfram Sang wrote:
>
>> + * i2c_slave_mode_detect - detect operation mode
>
> I'd rather name it 'i2c_detect_slave_mode'
I will do a V4 with this change.
>
>> + * @dev: The device owning the bus
>> + *
>> + * This checks the device nodes for an I2C slave by checking the a
On Wed, Jan 25, 2017 at 11:01 PM, Wolfram Sang wrote:
> On Wed, Jan 25, 2017 at 10:50:09PM +0200, Andy Shevchenko wrote:
>> On Wed, 2017-01-25 at 21:45 +0100, Wolfram Sang wrote:
>> > > + * i2c_slave_mode_detect - detect operation mode
>> >
>> > I'd rather name it 'i2c_detect_slave_mode'
>>
>> Whe
On Wed, Jan 25, 2017 at 10:50:09PM +0200, Andy Shevchenko wrote:
> On Wed, 2017-01-25 at 21:45 +0100, Wolfram Sang wrote:
> > > + * i2c_slave_mode_detect - detect operation mode
> >
> > I'd rather name it 'i2c_detect_slave_mode'
>
> When I proposed that I kept in ming `git grep -n i2c_slave`.
"i
On Wed, 2017-01-25 at 21:45 +0100, Wolfram Sang wrote:
> > + * i2c_slave_mode_detect - detect operation mode
>
> I'd rather name it 'i2c_detect_slave_mode'
When I proposed that I kept in ming `git grep -n i2c_slave`.
> The code looks good to me, so we are close to go!
Thumb up!
--
Andy Shevch
> + * i2c_slave_mode_detect - detect operation mode
I'd rather name it 'i2c_detect_slave_mode'
> + * @dev: The device owning the bus
> + *
> + * This checks the device nodes for an I2C slave by checking the address
> + * used.
> + *
> + * Returns true if an I2C slave is detected, otherwise retu
This function has the purpose of mode detection by checking the
device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag.
Currently only checks using OF functions (ACPI slave not supported yet).
Signed-off-by: Luis Oliveira
Suggested-by: Andy Shevchenko
Reviewed-by: Andy Shevchenko
6 matches
Mail list logo
