Re: [PATCH v3] kvm: Fix page ageing bugs

2014-09-22 Thread Andres Lagar-Cavilla
On Mon, Sep 22, 2014 at 2:48 PM, Paolo Bonzini wrote: > Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto: >> + __entry->gfn= gfn; >> + __entry->hva= ((gfn - slot->base_gfn) >> > > This must be <<. Correct, thanks. > >> +

Re: [PATCH v3] kvm: Fix page ageing bugs

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto: > + __entry->gfn= gfn; > + __entry->hva= ((gfn - slot->base_gfn) >> This must be <<. > + PAGE_SHIFT) + slot->userspace_addr; > + /* > +

[PATCH v3] kvm: Fix page ageing bugs

2014-09-22 Thread Andres Lagar-Cavilla
1. We were calling clear_flush_young_notify in unmap_one, but we are within an mmu notifier invalidate range scope. The spte exists no more (due to range_start) and the accessed bit info has already been propagated (due to kvm_pfn_set_accessed). Simply call clear_flush_young. 2. We clear_flush_you