Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-15 Thread Jarkko Sakkinen
On Wed, Jan 13, 2021 at 10:42:12PM -0600, Haitao Huang wrote: > On Mon, 11 Jan 2021 18:08:10 -0600, Jarkko Sakkinen > wrote: > > > On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > > > On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > > > > Add

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-14 Thread Jarkko Sakkinen
On Wed, Jan 13, 2021 at 09:46:02AM -0800, Paul E. McKenney wrote: > On Wed, Jan 13, 2021 at 07:18:23PM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 12, 2021 at 07:35:50PM +0100, Borislav Petkov wrote: > > > + paulmck. > > > > > > On Tue, Jan 12, 2021 at 02:08:10AM +0200, Jarkko Sakkinen wrote: >

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-13 Thread Haitao Huang
On Mon, 11 Jan 2021 18:08:10 -0600, Jarkko Sakkinen wrote: On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > Add synchronize_srcu_expedited() to sgx_encl_release() to catch a grace > period initiated by

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 07:00:33PM +0100, Borislav Petkov wrote: > On Wed, Jan 13, 2021 at 09:46:02AM -0800, Paul E. McKenney wrote: > > < Lemme trim that mail fat > > > > It seems to me that loading and unloading SGX enclaves qualifies as a > > configuration operation, so use of

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-13 Thread Borislav Petkov
On Wed, Jan 13, 2021 at 09:46:02AM -0800, Paul E. McKenney wrote: < Lemme trim that mail fat > > It seems to me that loading and unloading SGX enclaves qualifies as a > configuration operation, so use of synchronize_srcu_expedited() should be > just fine in that case. This of course implies

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-13 Thread Paul E. McKenney
On Wed, Jan 13, 2021 at 07:18:23PM +0200, Jarkko Sakkinen wrote: > On Tue, Jan 12, 2021 at 07:35:50PM +0100, Borislav Petkov wrote: > > + paulmck. > > > > On Tue, Jan 12, 2021 at 02:08:10AM +0200, Jarkko Sakkinen wrote: > > > On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > > >

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-13 Thread Jarkko Sakkinen
On Tue, Jan 12, 2021 at 07:35:50PM +0100, Borislav Petkov wrote: > + paulmck. > > On Tue, Jan 12, 2021 at 02:08:10AM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > > > On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > > > >

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-12 Thread Paul E. McKenney
On Tue, Jan 12, 2021 at 07:35:50PM +0100, Borislav Petkov wrote: > + paulmck. > > On Tue, Jan 12, 2021 at 02:08:10AM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > > > On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > > > >

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-12 Thread Borislav Petkov
+ paulmck. On Tue, Jan 12, 2021 at 02:08:10AM +0200, Jarkko Sakkinen wrote: > On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > > On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > > > Add synchronize_srcu_expedited() to sgx_encl_release() to catch a grace > > >

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-11 Thread Jarkko Sakkinen
On Mon, Jan 04, 2021 at 02:22:05PM -0600, Haitao Huang wrote: > On Wed, 16 Dec 2020 07:49:20 -0600, Jarkko Sakkinen > wrote: > > > Add synchronize_srcu_expedited() to sgx_encl_release() to catch a grace > > period initiated by sgx_mmu_notifier_release(). > > > > A trivial example of a failing

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-11 Thread Jarkko Sakkinen
On Tue, Jan 05, 2021 at 03:57:49PM +0100, Borislav Petkov wrote: > On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > > Add synchronize_srcu_expedited() to sgx_encl_release() to catch a grace > > period initiated by sgx_mmu_notifier_release(). > > > > A trivial example of a

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-05 Thread Borislav Petkov
On Wed, Dec 16, 2020 at 03:49:20PM +0200, Jarkko Sakkinen wrote: > Add synchronize_srcu_expedited() to sgx_encl_release() to catch a grace > period initiated by sgx_mmu_notifier_release(). > > A trivial example of a failing sequence with tasks A and B: > > 1. A: -> sgx_release() > 2. B: ->

Re: [PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2021-01-04 Thread Haitao Huang
On Wed, 16 Dec 2020 07:49:20 -0600, Jarkko Sakkinen wrote: Add synchronize_srcu_expedited() to sgx_encl_release() to catch a grace period initiated by sgx_mmu_notifier_release(). A trivial example of a failing sequence with tasks A and B: 1. A: -> sgx_release() 2. B: ->

[PATCH v3] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2020-12-16 Thread Jarkko Sakkinen
Add synchronize_srcu_expedited() to sgx_encl_release() to catch a grace period initiated by sgx_mmu_notifier_release(). A trivial example of a failing sequence with tasks A and B: 1. A: -> sgx_release() 2. B: -> sgx_mmu_notifier_release() 3. B: -> list_del_rcu() 3. A: -> sgx_encl_release() 4. A: