Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-13 Thread Neftin, Sasha
On 12/10/2020 07:28, Neftin, Sasha wrote: On 12/10/2020 04:24, Alexander Duyck wrote: On Wed, Dec 9, 2020 at 6:44 AM Hans de Goede wrote: Hi, On 12/8/20 5:14 PM, Alexander Duyck wrote: On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: Hi, On 12/8/20 6:08 AM, Neftin, Sasha wrote: On

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-09 Thread Neftin, Sasha
On 12/10/2020 04:24, Alexander Duyck wrote: On Wed, Dec 9, 2020 at 6:44 AM Hans de Goede wrote: Hi, On 12/8/20 5:14 PM, Alexander Duyck wrote: On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: Hi, On 12/8/20 6:08 AM, Neftin, Sasha wrote: On 12/7/2020 17:41, Limonciello, Mario wrote:

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-09 Thread Alexander Duyck
On Wed, Dec 9, 2020 at 6:44 AM Hans de Goede wrote: > > Hi, > > On 12/8/20 5:14 PM, Alexander Duyck wrote: > > On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 12/8/20 6:08 AM, Neftin, Sasha wrote: > >>> On 12/7/2020 17:41, Limonciello, Mario wrote: > > First of

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-09 Thread Hans de Goede
Hi, On 12/8/20 5:14 PM, Alexander Duyck wrote: > On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: >> >> Hi, >> >> On 12/8/20 6:08 AM, Neftin, Sasha wrote: >>> On 12/7/2020 17:41, Limonciello, Mario wrote: > First of all thank you for working on this. > > I must say though that I

RE: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-08 Thread Limonciello, Mario
> > Based on the earlier thread you had referenced and his comment here it > sounds like while adding time will work for most cases, it doesn't > solve it for all cases. The problem is as a vendor you are usually > stuck looking for a solution that will work for all cases which can > lead to

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-08 Thread Alexander Duyck
On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: > > Hi, > > On 12/8/20 6:08 AM, Neftin, Sasha wrote: > > On 12/7/2020 17:41, Limonciello, Mario wrote: > >>> First of all thank you for working on this. > >>> > >>> I must say though that I don't like the approach taken here very > >>> much. >

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-08 Thread Hans de Goede
Hi, On 12/8/20 6:08 AM, Neftin, Sasha wrote: > On 12/7/2020 17:41, Limonciello, Mario wrote: >>> First of all thank you for working on this. >>> >>> I must say though that I don't like the approach taken here very >>> much. >>> >>> This is not so much a criticism of this series as it is a

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-07 Thread Neftin, Sasha
On 12/7/2020 17:41, Limonciello, Mario wrote: First of all thank you for working on this. I must say though that I don't like the approach taken here very much. This is not so much a criticism of this series as it is a criticism of the earlier decision to simply disable s0ix on all devices

RE: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-07 Thread Limonciello, Mario
> First of all thank you for working on this. > > I must say though that I don't like the approach taken here very > much. > > This is not so much a criticism of this series as it is a criticism > of the earlier decision to simply disable s0ix on all devices > with the i219-LM + and active ME.

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-07 Thread Hans de Goede
Hi, On 12/4/20 9:09 PM, Mario Limonciello wrote: > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions > caused by an

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-06 Thread Alexander Duyck
On Sat, Dec 5, 2020 at 3:49 PM Jakub Kicinski wrote: > > On Fri, 4 Dec 2020 14:38:03 -0800 Alexander Duyck wrote: > > > > The patches look good to me. Just need to address the minor issue that > > > > seems to have been present prior to the introduction of this patch > > > > set. > > > > > > > >

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-05 Thread Jakub Kicinski
On Fri, 4 Dec 2020 14:38:03 -0800 Alexander Duyck wrote: > > > The patches look good to me. Just need to address the minor issue that > > > seems to have been present prior to the introduction of this patch > > > set. > > > > > > Reviewed-by: Alexander Duyck > > > > Thanks for your review.

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Alexander Duyck
v; > > Jakub > > Kicinski; Sasha Netfin; Aaron Brown; Stefan Assmann; David Miller; David > > Arcari; Shen, Yijun; Yuan, Perry; anthony.w...@canonical.com > > Subject: Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM > > > > > > [EXTERNAL

RE: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Limonciello, Mario
; Arcari; Shen, Yijun; Yuan, Perry; anthony.w...@canonical.com > Subject: Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM > > > [EXTERNAL EMAIL] > > On Fri, Dec 4, 2020 at 12:09 PM Mario Limonciello > wrote: > > > > commit e086ba2fccda ("e1000e: disabl

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Alexander Duyck
On Fri, Dec 4, 2020 at 12:09 PM Mario Limonciello wrote: > > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions >

[PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Mario Limonciello
commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") disabled s0ix flows for systems that have various incarnations of the i219-LM ethernet controller. This was done because of some regressions caused by an earlier commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for