Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-23 Thread Stephen Boyd
Quoting Doug Anderson (2019-01-23 15:24:36) > Hi, > > On Tue, Jan 22, 2019 at 5:09 PM Bjorn Andersson > wrote: > > > > On Tue 22 Jan 16:40 PST 2019, Doug Anderson wrote: > > > > > Hi, > > > > > > On Tue, Jan 22, 2019 at 4:26 PM Bjorn Andersson > > > wrote: > > > > > > + clocks =

Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-23 Thread Doug Anderson
Hi, On Tue, Jan 22, 2019 at 5:09 PM Bjorn Andersson wrote: > > On Tue 22 Jan 16:40 PST 2019, Doug Anderson wrote: > > > Hi, > > > > On Tue, Jan 22, 2019 at 4:26 PM Bjorn Andersson > > wrote: > > > > > + clocks = <_board>; > > > > > + clock-names = "xo"; > > > > > > >

Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-22 Thread Bjorn Andersson
On Tue 22 Jan 16:40 PST 2019, Doug Anderson wrote: > Hi, > > On Tue, Jan 22, 2019 at 4:26 PM Bjorn Andersson > wrote: > > > > + clocks = <_board>; > > > > + clock-names = "xo"; > > > > > > I've found that nearly all the places that refer to xo_board are wrong > > >

Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-22 Thread Doug Anderson
Hi, On Tue, Jan 22, 2019 at 4:26 PM Bjorn Andersson wrote: > > > + clocks = <_board>; > > > + clock-names = "xo"; > > > > I've found that nearly all the places that refer to xo_board are wrong > > and should actually point to '< RPMH_CXO_CLK>'. Maybe yours > > should

Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-22 Thread Bjorn Andersson
On Tue 22 Jan 15:46 PST 2019, Doug Anderson wrote: > Hi, > > On Mon, Jan 21, 2019 at 9:52 PM Bjorn Andersson > wrote: > > > > Add the ADSP and CDSP nodes for PAS-based remoteproc, supporting booting > > these cores on e.g. the MTP, and enable the same for the MTP. > > > > Signed-off-by: Bjorn

Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-22 Thread Doug Anderson
Hi, On Mon, Jan 21, 2019 at 9:52 PM Bjorn Andersson wrote: > > Add the ADSP and CDSP nodes for PAS-based remoteproc, supporting booting > these cores on e.g. the MTP, and enable the same for the MTP. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > - New patch > >

[PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-21 Thread Bjorn Andersson
Add the ADSP and CDSP nodes for PAS-based remoteproc, supporting booting these cores on e.g. the MTP, and enable the same for the MTP. Signed-off-by: Bjorn Andersson --- Changes since v2: - New patch arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 8 arch/arm64/boot/dts/qcom/sdm845.dtsi|