Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-29 Thread Johannes Weiner
On Wed, Jul 29, 2015 at 10:41:10AM +0530, PINTU KUMAR wrote: > I was talking about only the following case. > Instead of hard coding the hibernation_mode in shrink_all_memory, > We can set it at runtime. > > - .hibernation_mode = 1, > > + if (system_entering_hibernation()) >

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-29 Thread Johannes Weiner
On Wed, Jul 29, 2015 at 10:41:10AM +0530, PINTU KUMAR wrote: I was talking about only the following case. Instead of hard coding the hibernation_mode in shrink_all_memory, We can set it at runtime. - .hibernation_mode = 1, + if (system_entering_hibernation()) +

RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-28 Thread PINTU KUMAR
ack.org; linux- > p...@vger.kernel.org; qiuxi...@huawei.com; valdis.kletni...@vt.edu; > c...@samsung.com; pintu_agar...@yahoo.com; vishnu...@samsung.com; > rohit...@samsung.com; iqbal@samsung.com; pintu.p...@gmail.com; > pint...@outlook.com > Subject: Re: [PATCH v3 1/1] kernel/sy

RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-28 Thread PINTU KUMAR
; valdis.kletni...@vt.edu; c...@samsung.com; pintu_agar...@yahoo.com; vishnu...@samsung.com; rohit...@samsung.com; iqbal@samsung.com; pintu.p...@gmail.com; pint...@outlook.com Subject: Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature On Wed, Jul 22, 2015 at 06:33

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-22 Thread Mel Gorman
On Wed, Jul 22, 2015 at 06:33:26PM +0530, PINTU KUMAR wrote: > Dear Mel, thank you very much for your comments and suggestions. > I will drop this one and look on further improving direct_reclaim and > compaction. > Just few more comments below before I close. > > Also, during this patch, I feel

RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-22 Thread PINTU KUMAR
l.org; qiuxi...@huawei.com; valdis.kletni...@vt.edu; > c...@samsung.com; pintu_agar...@yahoo.com; vishnu...@samsung.com; > rohit...@samsung.com; iqbal@samsung.com; pintu.p...@gmail.com; > pint...@outlook.com > Subject: Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory

RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-22 Thread PINTU KUMAR
; pintu_agar...@yahoo.com; vishnu...@samsung.com; rohit...@samsung.com; iqbal@samsung.com; pintu.p...@gmail.com; pint...@outlook.com Subject: Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature On Mon, Jul 20, 2015 at 09:43:02PM +0530, PINTU KUMAR wrote: Hi

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-22 Thread Mel Gorman
On Wed, Jul 22, 2015 at 06:33:26PM +0530, PINTU KUMAR wrote: Dear Mel, thank you very much for your comments and suggestions. I will drop this one and look on further improving direct_reclaim and compaction. Just few more comments below before I close. Also, during this patch, I feel that

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread Mel Gorman
On Mon, Jul 20, 2015 at 09:43:02PM +0530, PINTU KUMAR wrote: > Hi, > > Thank you all for reviewing the patch and providing your valuable comments and > suggestions. > During the ELC conference many people suggested to release the patch to > mainline, so this patch, to get others opinion. >

RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread PINTU KUMAR
m; iqbal@samsung.com; pintu.p...@gmail.com; > pint...@outlook.com > Subject: Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory > feature > > On Mon, Jul 20, 2015 at 09:59:04AM +0530, Pintu Kumar wrote: > > This patch provides 2 things: > > 1. Add new control ca

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread Michal Hocko
On Mon 20-07-15 09:28:10, Mel Gorman wrote: [...] > If high-order allocation latency or reliability is important then you > really need a different solution because unless this thing runs > continually to keep memory unused then it'll eventually fail hard and > the system will perform poorly in

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread Mel Gorman
On Mon, Jul 20, 2015 at 09:59:04AM +0530, Pintu Kumar wrote: > This patch provides 2 things: > 1. Add new control called shrink_memory in /proc/sys/vm/. > This control can be used to aggressively reclaim memory system-wide > in one shot from the user space. A value of 1 will instruct the > kernel

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread Mel Gorman
On Mon, Jul 20, 2015 at 09:59:04AM +0530, Pintu Kumar wrote: This patch provides 2 things: 1. Add new control called shrink_memory in /proc/sys/vm/. This control can be used to aggressively reclaim memory system-wide in one shot from the user space. A value of 1 will instruct the kernel to

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread Michal Hocko
On Mon 20-07-15 09:28:10, Mel Gorman wrote: [...] If high-order allocation latency or reliability is important then you really need a different solution because unless this thing runs continually to keep memory unused then it'll eventually fail hard and the system will perform poorly in the

Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread Mel Gorman
On Mon, Jul 20, 2015 at 09:43:02PM +0530, PINTU KUMAR wrote: Hi, Thank you all for reviewing the patch and providing your valuable comments and suggestions. During the ELC conference many people suggested to release the patch to mainline, so this patch, to get others opinion.

RE: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-20 Thread PINTU KUMAR
: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature On Mon, Jul 20, 2015 at 09:59:04AM +0530, Pintu Kumar wrote: This patch provides 2 things: 1. Add new control called shrink_memory in /proc/sys/vm/. This control can be used to aggressively reclaim memory system-wide

[PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-19 Thread Pintu Kumar
This patch provides 2 things: 1. Add new control called shrink_memory in /proc/sys/vm/. This control can be used to aggressively reclaim memory system-wide in one shot from the user space. A value of 1 will instruct the kernel to reclaim as much as totalram_pages in the system. Example: echo 1 >

[PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory feature

2015-07-19 Thread Pintu Kumar
This patch provides 2 things: 1. Add new control called shrink_memory in /proc/sys/vm/. This control can be used to aggressively reclaim memory system-wide in one shot from the user space. A value of 1 will instruct the kernel to reclaim as much as totalram_pages in the system. Example: echo 1