Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-27 Thread Avi Kivity
On 09/24/2012 02:32 PM, Xiao Guangrong wrote: > 3 places after the whole patchset (There are some cleanups after this patch). > >> and one by even stronger is_error_pfn(). > > This one is: > > | if (!is_error_pfn(pfn)) { > |kvm_release_pfn_clean(pfn); > |ret

Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-24 Thread Xiao Guangrong
On 09/24/2012 08:04 PM, Gleb Natapov wrote: > On Mon, Sep 24, 2012 at 07:49:37PM +0800, Xiao Guangrong wrote: >> On 09/24/2012 07:24 PM, Gleb Natapov wrote: >>> On Mon, Sep 24, 2012 at 12:59:32PM +0800, Xiao Guangrong wrote: On 09/23/2012 05:13 PM, Gleb Natapov wrote: > On Fri, Sep 21, 201

Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-24 Thread Gleb Natapov
On Mon, Sep 24, 2012 at 07:49:37PM +0800, Xiao Guangrong wrote: > On 09/24/2012 07:24 PM, Gleb Natapov wrote: > > On Mon, Sep 24, 2012 at 12:59:32PM +0800, Xiao Guangrong wrote: > >> On 09/23/2012 05:13 PM, Gleb Natapov wrote: > >>> On Fri, Sep 21, 2012 at 02:57:19PM +0800, Xiao Guangrong wrote: >

Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-24 Thread Xiao Guangrong
On 09/24/2012 07:24 PM, Gleb Natapov wrote: > On Mon, Sep 24, 2012 at 12:59:32PM +0800, Xiao Guangrong wrote: >> On 09/23/2012 05:13 PM, Gleb Natapov wrote: >>> On Fri, Sep 21, 2012 at 02:57:19PM +0800, Xiao Guangrong wrote: We can not directly call kvm_release_pfn_clean to release the pfn >>>

Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-24 Thread Gleb Natapov
On Mon, Sep 24, 2012 at 12:59:32PM +0800, Xiao Guangrong wrote: > On 09/23/2012 05:13 PM, Gleb Natapov wrote: > > On Fri, Sep 21, 2012 at 02:57:19PM +0800, Xiao Guangrong wrote: > >> We can not directly call kvm_release_pfn_clean to release the pfn > >> since we can meet noslot pfn which is used to

Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-23 Thread Xiao Guangrong
On 09/23/2012 05:13 PM, Gleb Natapov wrote: > On Fri, Sep 21, 2012 at 02:57:19PM +0800, Xiao Guangrong wrote: >> We can not directly call kvm_release_pfn_clean to release the pfn >> since we can meet noslot pfn which is used to cache mmio info into >> spte >> > Wouldn't it be better to move the che

Re: [PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-23 Thread Gleb Natapov
On Fri, Sep 21, 2012 at 02:57:19PM +0800, Xiao Guangrong wrote: > We can not directly call kvm_release_pfn_clean to release the pfn > since we can meet noslot pfn which is used to cache mmio info into > spte > Wouldn't it be better to move the check into kvm_release_pfn_clean()? > Signed-off-by:

[PATCH v3 1/7] KVM: MMU: fix release noslot pfn

2012-09-20 Thread Xiao Guangrong
We can not directly call kvm_release_pfn_clean to release the pfn since we can meet noslot pfn which is used to cache mmio info into spte Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c |6 -- arch/x86/kvm/paging_tmpl.h |6 -- 2 files changed, 8 insertions(+), 4 dele