Hi Peter,
On Wed, 7 May 2014 19:35:32 +0200, Peter Zijlstra wrote:
> On Wed, May 07, 2014 at 07:19:14PM +0200, Stephane Eranian wrote:
>> > $ while :; do ./foo /bin/sleep 5 ; done
>> >
>> > and try and break out using ^C
>> >
>> What I usually do here is hit ^Z, then kill the job.
>> But I agree
Hi Peter,
On Wed, 7 May 2014 19:35:32 +0200, Peter Zijlstra wrote:
On Wed, May 07, 2014 at 07:19:14PM +0200, Stephane Eranian wrote:
$ while :; do ./foo /bin/sleep 5 ; done
and try and break out using ^C
What I usually do here is hit ^Z, then kill the job.
But I agree it would be nicer
On Wed, May 07, 2014 at 07:19:14PM +0200, Stephane Eranian wrote:
> > $ while :; do ./foo /bin/sleep 5 ; done
> >
> > and try and break out using ^C
> >
> What I usually do here is hit ^Z, then kill the job.
> But I agree it would be nicer to handle this case automatically.
So that used to work.
On Wed, May 7, 2014 at 5:04 PM, Peter Zijlstra wrote:
> On Wed, Apr 30, 2014 at 09:24:08AM +0900, Namhyung Kim wrote:
>> Hi Jiri and Peter,
>>
>> On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
>> > On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
>> >> On Tue, Apr 29, 2014 at
On Wed, Apr 30, 2014 at 09:24:08AM +0900, Namhyung Kim wrote:
> Hi Jiri and Peter,
>
> On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
> > On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
> >> On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
> >> >
> >> >
On Wed, Apr 30, 2014 at 09:24:08AM +0900, Namhyung Kim wrote:
> Hi Jiri and Peter,
>
> On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
> > On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
> >> On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
> >> >
> >> >
On Wed, Apr 30, 2014 at 09:24:08AM +0900, Namhyung Kim wrote:
Hi Jiri and Peter,
On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
perf_counter tools:
On Wed, Apr 30, 2014 at 09:24:08AM +0900, Namhyung Kim wrote:
Hi Jiri and Peter,
On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
perf_counter tools:
On Wed, May 7, 2014 at 5:04 PM, Peter Zijlstra pet...@infradead.org wrote:
On Wed, Apr 30, 2014 at 09:24:08AM +0900, Namhyung Kim wrote:
Hi Jiri and Peter,
On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29,
On Wed, May 07, 2014 at 07:19:14PM +0200, Stephane Eranian wrote:
$ while :; do ./foo /bin/sleep 5 ; done
and try and break out using ^C
What I usually do here is hit ^Z, then kill the job.
But I agree it would be nicer to handle this case automatically.
So that used to work. And note
Hi Jiri and Peter,
On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
> On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
>> On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
>> >
>> > perf_counter tools: Propagate signals properly
>> > commit
On Thu, Apr 24, 2014 at 10:27:33PM +0900, Namhyung Kim wrote:
> static void record__sig_exit(int exit_status __maybe_unused, void *arg)
> {
> - struct record *rec = arg;
> - int status;
> -
> - if (rec->evlist->workload.pid > 0) {
> - if (!child_finished)
> -
On Tue, Apr 29, 2014 at 01:33:04PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
> > On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
> > >
> > > perf_counter tools: Propagate signals properly
> > > commit
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
> >
> > perf_counter tools: Propagate signals properly
> > commit f7b7c26e01e51fe46097e11f179dc71ce7950084
> > Author: Peter Zijlstra
> > Date: Wed Jun 10
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
> >
> > perf_counter tools: Propagate signals properly
> > commit f7b7c26e01e51fe46097e11f179dc71ce7950084
> > Author: Peter Zijlstra
> > Date: Wed Jun 10
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
>
> perf_counter tools: Propagate signals properly
> commit f7b7c26e01e51fe46097e11f179dc71ce7950084
> Author: Peter Zijlstra
> Date: Wed Jun 10 15:55:59 2009 +0200
>
> but I dont think we need to do that
But but but, then
On Thu, Apr 24, 2014 at 10:27:33PM +0900, Namhyung Kim wrote:
SNIP
> - rec->bytes_written / 24);
> +out_child:
> + if (forks) {
> + int exit_status;
>
> - return 0;
> + if (!child_finished)
> + kill(rec->evlist->workload.pid,
On Thu, Apr 24, 2014 at 10:27:33PM +0900, Namhyung Kim wrote:
SNIP
> Reported-by: Stephane Eranian
> Signed-off-by: Namhyung Kim
> ---
> tools/perf/builtin-record.c | 121
> ++-
> 1 file changed, 51 insertions(+), 70 deletions(-)
>
> diff --git
On Thu, Apr 24, 2014 at 10:27:33PM +0900, Namhyung Kim wrote:
SNIP
Reported-by: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/builtin-record.c | 121
++-
1 file changed, 51 insertions(+), 70
On Thu, Apr 24, 2014 at 10:27:33PM +0900, Namhyung Kim wrote:
SNIP
- rec-bytes_written / 24);
+out_child:
+ if (forks) {
+ int exit_status;
- return 0;
+ if (!child_finished)
+ kill(rec-evlist-workload.pid, SIGTERM);
also
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
perf_counter tools: Propagate signals properly
commit f7b7c26e01e51fe46097e11f179dc71ce7950084
Author: Peter Zijlstra a.p.zijls...@chello.nl
Date: Wed Jun 10 15:55:59 2009 +0200
but I dont think we need to do that
But
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
perf_counter tools: Propagate signals properly
commit f7b7c26e01e51fe46097e11f179dc71ce7950084
Author: Peter Zijlstra a.p.zijls...@chello.nl
Date: Wed
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
perf_counter tools: Propagate signals properly
commit f7b7c26e01e51fe46097e11f179dc71ce7950084
Author: Peter Zijlstra a.p.zijls...@chello.nl
Date: Wed
On Tue, Apr 29, 2014 at 01:33:04PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
perf_counter tools: Propagate signals properly
commit f7b7c26e01e51fe46097e11f179dc71ce7950084
On Thu, Apr 24, 2014 at 10:27:33PM +0900, Namhyung Kim wrote:
static void record__sig_exit(int exit_status __maybe_unused, void *arg)
{
- struct record *rec = arg;
- int status;
-
- if (rec-evlist-workload.pid 0) {
- if (!child_finished)
-
Hi Jiri and Peter,
On Tue, 29 Apr 2014 13:37:47 +0200, Jiri Olsa wrote:
On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote:
On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote:
perf_counter tools: Propagate signals properly
commit
On Thu, Apr 24, 2014 at 3:27 PM, Namhyung Kim wrote:
> Currently perf record doesn't propagate the exit status of a workload
> given by the command line. But sometimes it'd useful if it's
> propagated so that a monitoring script can handle errors
> appropriately.
>
> To do that, it got rid of
On Thu, Apr 24, 2014 at 3:27 PM, Namhyung Kim namhy...@kernel.org wrote:
Currently perf record doesn't propagate the exit status of a workload
given by the command line. But sometimes it'd useful if it's
propagated so that a monitoring script can handle errors
appropriately.
To do that, it
Currently perf record doesn't propagate the exit status of a workload
given by the command line. But sometimes it'd useful if it's
propagated so that a monitoring script can handle errors
appropriately.
To do that, it got rid of exit handlers and run/call them directly in
the __cmd_record(). I
Currently perf record doesn't propagate the exit status of a workload
given by the command line. But sometimes it'd useful if it's
propagated so that a monitoring script can handle errors
appropriately.
To do that, it got rid of exit handlers and run/call them directly in
the __cmd_record(). I
30 matches
Mail list logo
