Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-17 Thread Michael Wang
inux-r...@vger.kernel.org; >> linux-kernel@vger.kernel.org; Tom Tucker; Steve Wise; >> Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal >> Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira > Weiny; >> Tom Talpey; Doug Ledford >> Subject: R

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-17 Thread Michael Wang
On 04/16/2015 06:43 PM, Jason Gunthorpe wrote: > On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: > >>> I would be very happy to see a patch that adds cap_ib_smi to the >>> current tree and states 'This patch is tested to have no change on the >>> binary compilation results' >> >>

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-17 Thread Michael Wang
@vger.kernel.org; Tom Tucker; Steve Wise; Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; Tom Talpey; Doug Ledford Subject: Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() On Tue, Apr 14, 2015 at 11:13:03AM

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-17 Thread Michael Wang
On 04/16/2015 06:43 PM, Jason Gunthorpe wrote: On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: I would be very happy to see a patch that adds cap_ib_smi to the current tree and states 'This patch is tested to have no change on the binary compilation results' There are too

RE: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-16 Thread Steve Wise
teve Wise; > Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal > Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; > Tom Talpey; Doug Ledford > Subject: Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() > > On Tue, Apr 14, 2015 at

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-16 Thread Jason Gunthorpe
On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: > > I would be very happy to see a patch that adds cap_ib_smi to the > > current tree and states 'This patch is tested to have no change on the > > binary compilation results' > > There are too much reform there (per-dev to per-port),

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-16 Thread Jason Gunthorpe
On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: I would be very happy to see a patch that adds cap_ib_smi to the current tree and states 'This patch is tested to have no change on the binary compilation results' There are too much reform there (per-dev to per-port), I guess

RE: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-16 Thread Steve Wise
Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; Tom Talpey; Doug Ledford Subject: Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: I would

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-14 Thread Michael Wang
On 04/13/2015 10:33 PM, Jason Gunthorpe wrote: > On Mon, Apr 13, 2015 at 02:36:45PM +0200, Michael Wang wrote: >> We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() >> is no longer necessary, thus clean it up. > > So, the net result is not looking too bad, but I'm

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-14 Thread Michael Wang
On 04/13/2015 10:33 PM, Jason Gunthorpe wrote: On Mon, Apr 13, 2015 at 02:36:45PM +0200, Michael Wang wrote: We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() is no longer necessary, thus clean it up. So, the net result is not looking too bad, but I'm confused

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-13 Thread Jason Gunthorpe
On Mon, Apr 13, 2015 at 02:36:45PM +0200, Michael Wang wrote: > We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() > is no longer necessary, thus clean it up. So, the net result is not looking too bad, but I'm confused about the structure of this series. Why introduce

[PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-13 Thread Michael Wang
We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() is no longer necessary, thus clean it up. Cc: Steve Wise Cc: Tom Talpey Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- include/rdma/ib_verbs.h |

Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-13 Thread Jason Gunthorpe
On Mon, Apr 13, 2015 at 02:36:45PM +0200, Michael Wang wrote: We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() is no longer necessary, thus clean it up. So, the net result is not looking too bad, but I'm confused about the structure of this series. Why introduce

[PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-13 Thread Michael Wang
We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() is no longer necessary, thus clean it up. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny