On 06/06/2017 09:19 AM, Christoph Hellwig wrote:
> Can you rebase on top of the new uuid_t type and the plain uuid_*
> prefixed helpers here:
>
> http://git.infradead.org/users/hch/uuid.git/shortlog/refs/heads/for-next
>
> I'll declare that branch stable soon and don't want to introduce
> more
On 06/06/2017 09:19 AM, Christoph Hellwig wrote:
> Can you rebase on top of the new uuid_t type and the plain uuid_*
> prefixed helpers here:
>
> http://git.infradead.org/users/hch/uuid.git/shortlog/refs/heads/for-next
>
> I'll declare that branch stable soon and don't want to introduce
> more
Can you rebase on top of the new uuid_t type and the plain uuid_*
prefixed helpers here:
http://git.infradead.org/users/hch/uuid.git/shortlog/refs/heads/for-next
I'll declare that branch stable soon and don't want to introduce
more users of the old types. Thanks!
Can you rebase on top of the new uuid_t type and the plain uuid_*
prefixed helpers here:
http://git.infradead.org/users/hch/uuid.git/shortlog/refs/heads/for-next
I'll declare that branch stable soon and don't want to introduce
more users of the old types. Thanks!
On 06/05/2017 07:31 AM, Christoph Hellwig wrote:
> What about a little helper like this: ?
>
> static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
> void *id, off_t *off)
> {
> struct nvme_ns_identifier_hdr hdr = {
> .nidt = type,
>
On 06/05/2017 07:31 AM, Christoph Hellwig wrote:
> What about a little helper like this: ?
>
> static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
> void *id, off_t *off)
> {
> struct nvme_ns_identifier_hdr hdr = {
> .nidt = type,
>
What about a little helper like this: ?
static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
void *id, off_t *off)
{
struct nvme_ns_identifier_hdr hdr = {
.nidt = type,
.nidl = len,
};
u16 status;
What about a little helper like this: ?
static u16 nvmet_copy_ns_identifier(struct nvmet_req *req, u8 type, u8 len,
void *id, off_t *off)
{
struct nvme_ns_identifier_hdr hdr = {
.nidt = type,
.nidl = len,
};
u16 status;
switch (type) {
case NVME_NQN_NVME:
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index cfc5c7fb0ab7..4c6cb5ea1186 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -46,6 +46,7 @@ struct nvmet_ns {
u32
switch (type) {
case NVME_NQN_NVME:
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index cfc5c7fb0ab7..4c6cb5ea1186 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -46,6 +46,7 @@ struct nvmet_ns {
u32
On Fri, Jun 02, 2017 at 04:46:40PM +0300, Sagi Grimberg wrote:
>
>> switch (type) {
>> case NVME_NQN_NVME:
>> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
>> index cfc5c7fb0ab7..4c6cb5ea1186 100644
>> --- a/drivers/nvme/target/nvmet.h
>> +++
On Fri, Jun 02, 2017 at 04:46:40PM +0300, Sagi Grimberg wrote:
>
>> switch (type) {
>> case NVME_NQN_NVME:
>> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
>> index cfc5c7fb0ab7..4c6cb5ea1186 100644
>> --- a/drivers/nvme/target/nvmet.h
>> +++
On 06/02/2017 03:46 PM, Sagi Grimberg wrote:
>> +uuid_beuuid;
>
> This should be uuid_le to match the rest of NVMe.
Ahm, are you sure?
$ PAGER= git grep -E uuid_\(l\|b\)e drivers/nvme
drivers/nvme/host/fabrics.c:61: uuid_be_gen(>id);
drivers/nvme/host/fabrics.c:78:
On 06/02/2017 03:46 PM, Sagi Grimberg wrote:
>> +uuid_beuuid;
>
> This should be uuid_le to match the rest of NVMe.
Ahm, are you sure?
$ PAGER= git grep -E uuid_\(l\|b\)e drivers/nvme
drivers/nvme/host/fabrics.c:61: uuid_be_gen(>id);
drivers/nvme/host/fabrics.c:78:
switch (type) {
case NVME_NQN_NVME:
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index cfc5c7fb0ab7..4c6cb5ea1186 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -46,6 +46,7 @@ struct nvmet_ns {
u32
switch (type) {
case NVME_NQN_NVME:
diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index cfc5c7fb0ab7..4c6cb5ea1186 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -46,6 +46,7 @@ struct nvmet_ns {
u32
A NVMe Identify NS command with a CNS value of '3' is expecting a list
of Namespace Identification Descriptor structures to be returned to
the host for the namespace requested in the namespace identify
command.
This Namespace Identification Descriptor structure consists of the
type of the
A NVMe Identify NS command with a CNS value of '3' is expecting a list
of Namespace Identification Descriptor structures to be returned to
the host for the namespace requested in the namespace identify
command.
This Namespace Identification Descriptor structure consists of the
type of the
18 matches
Mail list logo
