Re: [PATCH v3 4/7] kprobes: Replace %p with other pointer types

2018-04-27 Thread Masami Hiramatsu
On Sat, 28 Apr 2018 00:42:02 +0900 Masami Hiramatsu wrote: > > > +/* Caller must NOT call this in usual path. This is only for critical > > > case */ > > > void dump_kprobe(struct kprobe *kp) > > > { > > > - printk(KERN_WARNING "Dumping kprobe:\n"); > > > - printk(KERN_WARNING "Name: %s\nAddre

Re: [PATCH v3 4/7] kprobes: Replace %p with other pointer types

2018-04-27 Thread Masami Hiramatsu
On Fri, 27 Apr 2018 08:56:36 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > @@ -712,7 +712,7 @@ static void reuse_unused_kprobe(struct kprobe *ap) > > op = container_of(ap, struct optimized_kprobe, kp); > > if (unlikely(list_empty(&op->list))) > > printk(KERN_

Re: [PATCH v3 4/7] kprobes: Replace %p with other pointer types

2018-04-26 Thread Ingo Molnar
* Masami Hiramatsu wrote: > @@ -712,7 +712,7 @@ static void reuse_unused_kprobe(struct kprobe *ap) > op = container_of(ap, struct optimized_kprobe, kp); > if (unlikely(list_empty(&op->list))) > printk(KERN_WARNING "Warning: found a stray unused " > -

[PATCH v3 4/7] kprobes: Replace %p with other pointer types

2018-04-26 Thread Masami Hiramatsu
Replace %p with %pS or just remove it if unneeded. Signed-off-by: Masami Hiramatsu --- Changes in v3: - Do not use %px in any case. Changes in v2: - Rebased on linux-next --- kernel/kprobes.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/kerne