Re: [PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-19 Thread Song Liu
> On Feb 19, 2019, at 12:51 AM, Jiri Olsa wrote: > > On Tue, Feb 19, 2019 at 05:52:20AM +, Song Liu wrote: >> >> >>> On Feb 17, 2019, at 3:05 PM, Jiri Olsa wrote: >>> >>> On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote: >>> >>> SNIP >>> info_linear = bpf_program__get

Re: [PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-19 Thread Jiri Olsa
On Tue, Feb 19, 2019 at 05:52:20AM +, Song Liu wrote: > > > > On Feb 17, 2019, at 3:05 PM, Jiri Olsa wrote: > > > > On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote: > > > > SNIP > > > >>info_linear = bpf_program__get_prog_info_linear(fd, arrays); > >>if (IS_ERR_OR_NULL(in

Re: [PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-18 Thread Song Liu
> On Feb 17, 2019, at 3:05 PM, Jiri Olsa wrote: > > On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote: > > SNIP > >> info_linear = bpf_program__get_prog_info_linear(fd, arrays); >> if (IS_ERR_OR_NULL(info_linear)) { >> @@ -151,8 +165,8 @@ static int perf_event__synthesize_on

Re: [PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-17 Thread Jiri Olsa
On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote: SNIP > @@ -165,6 +179,19 @@ static int perf_event__synthesize_one_bpf_prog(struct > perf_tool *tool, > memcpy(bpf_event->tag, info->tag, BPF_TAG_SIZE); > memset((void *)event + event->header.size, 0, > machine

Re: [PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-17 Thread Jiri Olsa
On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote: SNIP > diff --git a/tools/perf/util/env.h b/tools/perf/util/env.h > index d01b8355f4ca..d0c53fe6d431 100644 > --- a/tools/perf/util/env.h > +++ b/tools/perf/util/env.h > @@ -3,7 +3,9 @@ > #define __PERF_ENV_H > > #include > +#include

Re: [PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-17 Thread Jiri Olsa
On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote: SNIP > info_linear = bpf_program__get_prog_info_linear(fd, arrays); > if (IS_ERR_OR_NULL(info_linear)) { > @@ -151,8 +165,8 @@ static int perf_event__synthesize_one_bpf_prog(struct > perf_tool *tool, >

[PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-15 Thread Song Liu
bpf_prog_info contains information necessary to annotate bpf programs. This patch saves bpf_prog_info for bpf programs loaded in the system. Signed-off-by: Song Liu --- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-top.c| 2 +- tools/perf/util/bpf-event.c | 35 +-- too