Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-12 Thread Dan Murphy
Pavel On 8/11/20 5:26 PM, Pavel Machek wrote: Hi! Well it depends on where we want to create the default cache values. Either we run through a for..loop during driver probe and delay device start up or we keep the simple arrays and increase the driver total size. for loop will be better.

Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-11 Thread Pavel Machek
Hi! > >>Well it depends on where we want to create the default cache values. > >> > >>Either we run through a for..loop during driver probe and delay device start > >>up or we keep the simple arrays and increase the driver total size. > >for loop will be better. > > > >Plus, REGCACHE_RBTREE is

Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-11 Thread Dan Murphy
Pavel On 8/11/20 5:01 PM, Pavel Machek wrote: Hi! Actually... This is quite impressive ammount of code to zero-initialize few registers. Could the regmap be told to set the range to zero, or use loops to reduce ammount of code? I am not aware of any regmap calls that will set a range of

Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-11 Thread Pavel Machek
Hi! > >Actually... This is quite impressive ammount of code to > >zero-initialize few registers. Could the regmap be told to set the > >range to zero, or use loops to reduce ammount of code? > > I am not aware of any regmap calls that will set a range of registers to a > certain value. > > Well

Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-11 Thread Dan Murphy
Hello On 8/11/20 5:54 AM, Pavel Machek wrote: Hi! +/* LP5009 and LP5012 registers */ +#define LP5012_BNK_BRT 0x03 +#define LP5012_BNKA_CLR0x04 +#define LP5012_BNKB_CLR0x05 +#define LP5012_BNKC_CLR0x06 +#define LP5012_LED0_BRT

Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-11 Thread Pavel Machek
Hi! > +/* LP5009 and LP5012 registers */ > +#define LP5012_BNK_BRT 0x03 > +#define LP5012_BNKA_CLR 0x04 > +#define LP5012_BNKB_CLR 0x05 > +#define LP5012_BNKC_CLR 0x06 > +#define LP5012_LED0_BRT 0x07 > +#define LP5012_LED1_BRT

Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-11 Thread Pavel Machek
Hi! > Introduce the LP5036/30/24/18/12/9 RGB LED driver. > The difference in these parts are the number of > LED outputs where the: > > LP5036 can control 36 LEDs > LP5030 can control 30 LEDs > LP5024 can control 24 LEDs > LP5018 can control 18 LEDs > LP5012 can control 12 LEDs > LP5009 can

Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-08-11 Thread Pavel Machek
Hi! > Introduce the LP5036/30/24/18/12/9 RGB LED driver. > The difference in these parts are the number of > LED outputs where the: > > LP5036 can control 36 LEDs > LP5030 can control 30 LEDs > LP5024 can control 24 LEDs > LP5018 can control 18 LEDs > LP5012 can control 12 LEDs > LP5009 can

[PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-07-22 Thread Dan Murphy
Introduce the LP5036/30/24/18/12/9 RGB LED driver. The difference in these parts are the number of LED outputs where the: LP5036 can control 36 LEDs LP5030 can control 30 LEDs LP5024 can control 24 LEDs LP5018 can control 18 LEDs LP5012 can control 12 LEDs LP5009 can control 9 LEDs The device