Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-20 Thread Mark Brown
On Tue, Feb 09, 2016 at 03:12:29PM +0200, Georgi Djakov wrote: > The SAW (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper) > is part of the SPM subsystem. It is a hardware block in the Qualcomm > chipsets that regulates the power to the CPU cores on platform such as > apq8064, msm8974,

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-12 Thread Mark Brown
On Thu, Feb 11, 2016 at 04:17:55PM -0800, Stephen Boyd wrote: > On 02/11, Georgi Djakov wrote: > > 8064 uses SSBI instead of SPMI and we currently do not have any > > existing regulator support upstream yet. So this driver is not > > duplicating any existing regulator. We should decide whether to

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-11 Thread Stephen Boyd
On 02/11, Georgi Djakov wrote: > On 02/11/2016 12:46 AM, Stephen Boyd wrote: > > On 02/10, Mark Brown wrote: > >> On Wed, Feb 10, 2016 at 11:04:36AM -0800, Stephen Boyd wrote: > >> > [..] > >>> I'm not really excited about the binding we have here either. > >>> We're going to have two places in DT

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-11 Thread Georgi Djakov
On 02/11/2016 12:46 AM, Stephen Boyd wrote: > On 02/10, Mark Brown wrote: >> On Wed, Feb 10, 2016 at 11:04:36AM -0800, Stephen Boyd wrote: >> [..] >>> I'm not really excited about the binding we have here either. >>> We're going to have two places in DT where we've created a >>> regulator for the s

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Stephen Boyd
On 02/10, Mark Brown wrote: > On Wed, Feb 10, 2016 at 11:04:36AM -0800, Stephen Boyd wrote: > > > I don't follow the rest of your mail though. Are you suggesting > > that in this case we put the regulator control into the PMIC > > regulator driver (qcom_spmi-regulator.c) and then use a > > syscon/

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Mark Brown
On Wed, Feb 10, 2016 at 11:04:36AM -0800, Stephen Boyd wrote: > I don't follow the rest of your mail though. Are you suggesting > that in this case we put the regulator control into the PMIC > regulator driver (qcom_spmi-regulator.c) and then use a > syscon/regmap there to change the voltages insi

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Stephen Boyd
On 02/10, Mark Brown wrote: > On Wed, Feb 10, 2016 at 10:36:51AM -0800, Stephen Boyd wrote: > > On 02/10, Georgi Djakov wrote: > > > In some designs we have to talk to the PMIC with SPMI > > transactions to change the mode depending on the voltages. How do > > we plan to handle that case where the

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Mark Brown
On Wed, Feb 10, 2016 at 09:42:23AM -0700, Lina Iyer wrote: > The offsets are the simple part. On other QCOM SoCs the voltage is > regulated by the SAW attached to the L2 cache controller. They have a > single rail that supplies power to all the cores and the L2, with > ability to change the number

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Mark Brown
On Wed, Feb 10, 2016 at 10:36:51AM -0800, Stephen Boyd wrote: > On 02/10, Georgi Djakov wrote: > > The purpose of this patch it to add support for 8064. Supporting other > > SoCs requires just read/writing at different offsets. To handle this we > > can convert the above defines to a table contai

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Stephen Boyd
On 02/10, Georgi Djakov wrote: > Hi Lina, > Thanks for reviewing. > > On 02/10/2016 12:21 AM, Lina Iyer wrote: > > On Tue, Feb 09 2016 at 06:13 -0700, Georgi Djakov wrote: > [..] > >> +#defineSPM_REG_STS_10x10 > >> +#defineSPM_REG_VCTL0x14 > >> +#defineSPM_REG_P

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Lina Iyer
On Wed, Feb 10 2016 at 03:13 -0700, Mark Brown wrote: On Tue, Feb 09, 2016 at 03:21:54PM -0700, Lina Iyer wrote: On Tue, Feb 09 2016 at 06:13 -0700, Georgi Djakov wrote: Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message,

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Georgi Djakov
Hi Lina, Thanks for reviewing. On 02/10/2016 12:21 AM, Lina Iyer wrote: > On Tue, Feb 09 2016 at 06:13 -0700, Georgi Djakov wrote: [..] >> +#defineSPM_REG_STS_10x10 >> +#defineSPM_REG_VCTL0x14 >> +#defineSPM_REG_PMIC_DATA_00x28 >> +#defineSPM_REG_PMI

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-10 Thread Mark Brown
On Tue, Feb 09, 2016 at 03:21:54PM -0700, Lina Iyer wrote: > On Tue, Feb 09 2016 at 06:13 -0700, Georgi Djakov wrote: Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling t

Re: [PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-09 Thread Lina Iyer
On Tue, Feb 09 2016 at 06:13 -0700, Georgi Djakov wrote: The SAW (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper) is part of the SPM subsystem. It is a hardware block in the Qualcomm chipsets that regulates the power to the CPU cores on platform such as apq8064, msm8974, apq8084 and

[PATCH v4] regulator: qcom-saw: Add support for SAW regulators

2016-02-09 Thread Georgi Djakov
The SAW (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper) is part of the SPM subsystem. It is a hardware block in the Qualcomm chipsets that regulates the power to the CPU cores on platform such as apq8064, msm8974, apq8084 and others. Signed-off-by: Georgi Djakov --- Changes since