Re: [PATCH v4] spi: spi-imx: add DMA support

2014-08-28 Thread Robin Gong
On Wed, Aug 27, 2014 at 11:12:08AM +0530, sanjeev sharma wrote: > On Sat, Aug 23, 2014 at 5:43 AM, Robin Gong wrote: > > > + /* > > +* Configure the DMA register: setup the watermark > > +* and enable DMA request. > > +*/ > > + if (spi_imx->dma_is_inited) { > >

Re: [PATCH v4] spi: spi-imx: add DMA support

2014-08-26 Thread Robin Gong
On Tue, Aug 26, 2014 at 09:26:40AM +0200, Marek Vasut wrote: > On Tuesday, August 26, 2014 at 09:17:59 AM, Robin Gong wrote: > > On Mon, Aug 25, 2014 at 10:07:22AM +0200, Marek Vasut wrote: > > > On Saturday, August 23, 2014 at 02:13:55 AM, Robin Gong wrote: > > > > After enable DMA > > > > > > Pl

Re: [PATCH v4] spi: spi-imx: add DMA support

2014-08-26 Thread Marek Vasut
On Tuesday, August 26, 2014 at 09:17:59 AM, Robin Gong wrote: > On Mon, Aug 25, 2014 at 10:07:22AM +0200, Marek Vasut wrote: > > On Saturday, August 23, 2014 at 02:13:55 AM, Robin Gong wrote: > > > After enable DMA > > > > Please also add a commit message which describes the change, not only > > s

Re: [PATCH v4] spi: spi-imx: add DMA support

2014-08-26 Thread Robin Gong
On Mon, Aug 25, 2014 at 10:07:22AM +0200, Marek Vasut wrote: > On Saturday, August 23, 2014 at 02:13:55 AM, Robin Gong wrote: > > After enable DMA > > Please also add a commit message which describes the change, not only some > test > results. > > [...] > Ok, I will enrich it in next version.

Re: [PATCH v4] spi: spi-imx: add DMA support

2014-08-25 Thread Marek Vasut
On Saturday, August 23, 2014 at 02:13:55 AM, Robin Gong wrote: > After enable DMA Please also add a commit message which describes the change, not only some test results. [...] > @@ -911,6 +1194,13 @@ static int spi_imx_probe(struct platform_device > *pdev) goto out_put_per; > > spi_imx-

[PATCH v4] spi: spi-imx: add DMA support

2014-08-22 Thread Robin Gong
After enable DMA spi-nor read speed is dd if=/dev/mtd0 of=/dev/null bs=1M count=1 1+0 records in 1+0 records out 1048576 bytes (1.0 MB) copied, 0.720402 s, 1.5 MB/s spi-nor write speed is dd if=/dev/zero of=/dev/mtd0 bs=1M count=1 1+0 records in 1+0 records out 1048576 bytes (1.0 MB) copied, 3.56