Re: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-12-02 Thread Caesar Wang
Hi Brain, 于 2015年12月03日 08:49, Brian Norris 写道: Hi Caesar, On Thu, Dec 03, 2015 at 08:42:38AM +0800, Caesar Wang wrote: ? 2015?12?03? 02:38, Brian Norris ??: [.] if (thermal->tshut_temp > INT_MAX) { CID 1341498: Integer handling issues (CONSTANT_EXPRESSION_RESULT)

Re: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-12-02 Thread Brian Norris
Hi Caesar, On Thu, Dec 03, 2015 at 08:42:38AM +0800, Caesar Wang wrote: > ? 2015?12?03? 02:38, Brian Norris ??: > > [.] > > if (thermal->tshut_temp > INT_MAX) { > > CID 1341498: Integer handling issues (CONSTANT_EXPRESSION_RESULT) > > "thermal->tshut_temp > 2147483647 /*

Re: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-12-02 Thread Brian Norris
Hi Caesar, On Mon, Nov 09, 2015 at 12:48:58PM +0800, Caesar Wang wrote: > As Temperature is currently represented as int not long in the thermal > framework since use int intead of unsigned long/long to represent > temperature to avoid bogus overheat detection when negative temperature >

Re: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-12-02 Thread Brian Norris
Hi Caesar, On Mon, Nov 09, 2015 at 12:48:58PM +0800, Caesar Wang wrote: > As Temperature is currently represented as int not long in the thermal > framework since use int intead of unsigned long/long to represent > temperature to avoid bogus overheat detection when negative temperature >

Re: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-12-02 Thread Brian Norris
Hi Caesar, On Thu, Dec 03, 2015 at 08:42:38AM +0800, Caesar Wang wrote: > ? 2015?12?03? 02:38, Brian Norris ??: > > [.] > > if (thermal->tshut_temp > INT_MAX) { > > CID 1341498: Integer handling issues (CONSTANT_EXPRESSION_RESULT) > > "thermal->tshut_temp > 2147483647 /*

Re: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-12-02 Thread Caesar Wang
Hi Brain, 于 2015年12月03日 08:49, Brian Norris 写道: Hi Caesar, On Thu, Dec 03, 2015 at 08:42:38AM +0800, Caesar Wang wrote: ? 2015?12?03? 02:38, Brian Norris ??: [.] if (thermal->tshut_temp > INT_MAX) { CID 1341498: Integer handling issues (CONSTANT_EXPRESSION_RESULT)

[PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-11-08 Thread Caesar Wang
As Temperature is currently represented as int not long in the thermal framework since use int intead of unsigned long/long to represent temperature to avoid bogus overheat detection when negative temperature reported. Signed-off-by: Caesar Wang --- Changes in v4: - fix the warning from the

[PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures

2015-11-08 Thread Caesar Wang
As Temperature is currently represented as int not long in the thermal framework since use int intead of unsigned long/long to represent temperature to avoid bogus overheat detection when negative temperature reported. Signed-off-by: Caesar Wang --- Changes in v4: - fix