Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Peter Zijlstra writes: > On Thu, Dec 22, 2016 at 11:19:17PM +1300, Eric W. Biederman wrote: >> Peter Zijlstra writes: >> >> > On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: >> >> >> >> And please make the array the last item in

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Peter Zijlstra writes: > On Thu, Dec 22, 2016 at 11:19:17PM +1300, Eric W. Biederman wrote: >> Peter Zijlstra writes: >> >> > On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: >> >> >> >> And please make the array the last item in the structure so that >> >> expanding or

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Thu, Dec 22, 2016 at 11:19:17PM +1300, Eric W. Biederman wrote: > Peter Zijlstra writes: > > > On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: > >> > >> And please make the array the last item in the structure so that > >> expanding or contracting it

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Thu, Dec 22, 2016 at 11:19:17PM +1300, Eric W. Biederman wrote: > Peter Zijlstra writes: > > > On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: > >> > >> And please make the array the last item in the structure so that > >> expanding or contracting it does not affect the

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Peter Zijlstra writes: > On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: >> >> And please make the array the last item in the structure so that >> expanding or contracting it does not affect the ability to read the rest >> of the structure. > > Sorry,

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Peter Zijlstra writes: > On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: >> >> And please make the array the last item in the structure so that >> expanding or contracting it does not affect the ability to read the rest >> of the structure. > > Sorry, sample_id must be last,

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: > > And please make the array the last item in the structure so that > expanding or contracting it does not affect the ability to read the rest > of the structure. Sorry, sample_id must be last, because hysterical crud :/

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: > > And please make the array the last item in the structure so that > expanding or contracting it does not affect the ability to read the rest > of the structure. Sorry, sample_id must be last, because hysterical crud :/

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Hari Bathini writes: > On Wednesday 21 December 2016 06:54 PM, Peter Zijlstra wrote: >> On Wed, Dec 21, 2016 at 06:39:01PM +0530, Hari Bathini wrote: >>> Hi Peter, I don't see how the tool can parse old records (with NAMESPACES_MAX == 7) if you set its

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Hari Bathini writes: > On Wednesday 21 December 2016 06:54 PM, Peter Zijlstra wrote: >> On Wed, Dec 21, 2016 at 06:39:01PM +0530, Hari Bathini wrote: >>> Hi Peter, I don't see how the tool can parse old records (with NAMESPACES_MAX == 7) if you set its NAMESPACES_MAX to say 10.

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Wednesday 21 December 2016 06:54 PM, Peter Zijlstra wrote: On Wed, Dec 21, 2016 at 06:39:01PM +0530, Hari Bathini wrote: Hi Peter, I don't see how the tool can parse old records (with NAMESPACES_MAX == 7) if you set its NAMESPACES_MAX to say 10. Then it will expect the link_info array to

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Wednesday 21 December 2016 06:54 PM, Peter Zijlstra wrote: On Wed, Dec 21, 2016 at 06:39:01PM +0530, Hari Bathini wrote: Hi Peter, I don't see how the tool can parse old records (with NAMESPACES_MAX == 7) if you set its NAMESPACES_MAX to say 10. Then it will expect the link_info array to

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Wed, Dec 21, 2016 at 06:39:01PM +0530, Hari Bathini wrote: > Hi Peter, > >I don't see how the tool can parse old records (with NAMESPACES_MAX == > >7) if you set its NAMESPACES_MAX to say 10. > > > >Then it will expect the link_info array to be 10 entries and either read > >past the end of the

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Wed, Dec 21, 2016 at 06:39:01PM +0530, Hari Bathini wrote: > Hi Peter, > >I don't see how the tool can parse old records (with NAMESPACES_MAX == > >7) if you set its NAMESPACES_MAX to say 10. > > > >Then it will expect the link_info array to be 10 entries and either read > >past the end of the

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Hi Peter, On Saturday 17 December 2016 01:35 AM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:51:20PM +0530, Hari Bathini wrote: Hi Peter, On Friday 16 December 2016 01:27 PM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: On Friday 16 December

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Hi Peter, On Saturday 17 December 2016 01:35 AM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:51:20PM +0530, Hari Bathini wrote: Hi Peter, On Friday 16 December 2016 01:27 PM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: On Friday 16 December

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Fri, Dec 16, 2016 at 11:51:20PM +0530, Hari Bathini wrote: > Hi Peter, > > > On Friday 16 December 2016 01:27 PM, Peter Zijlstra wrote: > >On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: > >> > >>On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: > >>>On Fri, Dec 16,

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Fri, Dec 16, 2016 at 11:51:20PM +0530, Hari Bathini wrote: > Hi Peter, > > > On Friday 16 December 2016 01:27 PM, Peter Zijlstra wrote: > >On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: > >> > >>On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: > >>>On Fri, Dec 16,

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Hi Peter, On Friday 16 December 2016 01:27 PM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: +struct perf_ns_link_info { +

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Hi Peter, On Friday 16 December 2016 01:27 PM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: +struct perf_ns_link_info { +

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: > > > On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: > >On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: > >>+struct perf_ns_link_info { > >>+ __u64 dev; > >>+ __u64 ino; > >>+}; > >>+ > >>+enum { >

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: > > > On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: > >On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: > >>+struct perf_ns_link_info { > >>+ __u64 dev; > >>+ __u64 ino; > >>+}; > >>+ > >>+enum { >

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: +struct perf_ns_link_info { + __u64 dev; + __u64 ino; +}; + +enum { + NET_NS_INDEX= 0, + UTS_NS_INDEX= 1, +

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Friday 16 December 2016 12:16 AM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: +struct perf_ns_link_info { + __u64 dev; + __u64 ino; +}; + +enum { + NET_NS_INDEX= 0, + UTS_NS_INDEX= 1, +

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: > +struct perf_ns_link_info { > + __u64 dev; > + __u64 ino; > +}; > + > +enum { > + NET_NS_INDEX= 0, > + UTS_NS_INDEX= 1, > + IPC_NS_INDEX= 2, > + PID_NS_INDEX=

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

On Fri, Dec 16, 2016 at 12:07:06AM +0530, Hari Bathini wrote: > +struct perf_ns_link_info { > + __u64 dev; > + __u64 ino; > +}; > + > +enum { > + NET_NS_INDEX= 0, > + UTS_NS_INDEX= 1, > + IPC_NS_INDEX= 2, > + PID_NS_INDEX=

[PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

With the advert of container technologies like docker, that depend on namespaces for isolation, there is a need for tracing support for namespaces. This patch introduces new PERF_RECORD_NAMESPACES event for tracing based on namespaces related info. Signed-off-by: Hari Bathini

[PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

With the advert of container technologies like docker, that depend on namespaces for isolation, there is a need for tracing support for namespaces. This patch introduces new PERF_RECORD_NAMESPACES event for tracing based on namespaces related info. Signed-off-by: Hari Bathini ---