[PATCH v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-11 Thread Yogesh Narayan Gaur
- Add driver for NXP FlexSPI host controller (0) What is the FlexSPI controller? FlexSPI is a flexsible SPI host controller which supports two SPI channels and up to 4 external devices. Each channel supports Single/Dual/Quad/Octal mode data transfer (1/2/4/8 bidirectional data lines) i.e.

[PATCH v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-11 Thread Yogesh Narayan Gaur
- Add driver for NXP FlexSPI host controller (0) What is the FlexSPI controller? FlexSPI is a flexsible SPI host controller which supports two SPI channels and up to 4 external devices. Each channel supports Single/Dual/Quad/Octal mode data transfer (1/2/4/8 bidirectional data lines) i.e.

Re: [PATCH v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-08 Thread Boris Brezillon
On Mon, 8 Oct 2018 16:41:39 +0530 Yogesh Gaur wrote: > +/* Registers used by the driver */ > +#define FSPI_MCR00x00 > +#define FSPI_MCR0_AHB_TIMEOUT_MASK GENMASK(31, 24) > +#define FSPI_MCR0_IP_TIMEOUT_MASKGENMASK(23, 16) You never mask the IP_TIMEOUT val, so you

Re: [PATCH v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-08 Thread Boris Brezillon
On Mon, 8 Oct 2018 16:41:39 +0530 Yogesh Gaur wrote: > +/* Registers used by the driver */ > +#define FSPI_MCR00x00 > +#define FSPI_MCR0_AHB_TIMEOUT_MASK GENMASK(31, 24) > +#define FSPI_MCR0_IP_TIMEOUT_MASKGENMASK(23, 16) You never mask the IP_TIMEOUT val, so you

[PATCH v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-08 Thread Yogesh Gaur
- Add driver for NXP FlexSPI host controller (0) What is the FlexSPI controller? FlexSPI is a flexsible SPI host controller which supports two SPI channels and up to 4 external devices. Each channel supports Single/Dual/Quad/Octal mode data transfer (1/2/4/8 bidirectional data lines) i.e.

[PATCH v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-08 Thread Yogesh Gaur
- Add driver for NXP FlexSPI host controller (0) What is the FlexSPI controller? FlexSPI is a flexsible SPI host controller which supports two SPI channels and up to 4 external devices. Each channel supports Single/Dual/Quad/Octal mode data transfer (1/2/4/8 bidirectional data lines) i.e.